feat(form-action-bar): add FormActionBar pattern#1404
Open
ByronDWall wants to merge 2 commits intomainfrom
Open
feat(form-action-bar): add FormActionBar pattern#1404ByronDWall wants to merge 2 commits intomainfrom
ByronDWall wants to merge 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: d11163a The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Introduces a flat-props FormActionBar that composes save, cancel, and optional delete buttons for form footers. Works inside DefaultPage.Footer, ModalPage.Footer, Drawer.Footer, and Dialog.Footer. Includes i18n support for button labels and group aria-label, React Aria slot passthrough for dialog close wiring, and uniform button sizing. Extends the i18n compile/generate scripts to recurse into pattern directories so pattern messages ship alongside component messages.
valoriecarli
force-pushed
the
FEC-430-form-action-bar
branch
from
ea101a4 to
d11163a
Compare
Contributor
|
Localization reminder: This PR adds or modifies `.i18n.ts` files. Please create a Jira ticket for the localization manager to initiate translation of any new or updated strings in Transifex. See LOC-1766 as an example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FormActionBarpattern atpackages/nimbus/src/patterns/actions/form-action-bar/— composes save, cancel, and optional delete buttons for form footersDefaultPage.Footer,ModalPage.Footer,Drawer.Footer, andDialog.Footer;cancelSlot="close"forwards the React Aria close slot for dialog dismissalDefaultPageandModalPagedev docs/stories to demonstrate the new pattern and point away from manual button compositionJira: FEC-430
Test plan
form-action-bar.stories.tsxpass (9 tests)modal-page.stories.tsxanddefault-page.stories.tsxpass (22 tests)pnpm --filter @commercetools/nimbus typecheckcleanpnpm --filter @commercetools/nimbus buildsucceeds; dist types includecancelSlotandbuttonSizeNotes
Non-English locale files currently ship English placeholders; final translations will land via Transifex (noted in the changeset).