fix(vitest): silence Vite native configLoader warnings - #1922
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Contributor
Bundle Size ReportLast updated: 2026-08-18 18:41:03 UTC
Baseline source: comment-chain |
|
Tip All tests passed and all changes approved!🟢 UI Tests: 1207 tests unchanged |
misama-ct
approved these changes
Aug 17, 2026
ByronDWall
force-pushed
the
fix-vitest-native-configloader-warnings
branch
from
August 17, 2026 20:38
a8b721e to
aeeac00
Compare
Vite's configLoader: "native" (the future default) can't load config files that use ESM syntax under CommonJS resolution or extensionless relative imports. Fix both classes of warning: - Rename root-level *.config.ts files (and packages/design-token-ts-plugin/vitest.config.ts) to .mts, since the nearest package.json has no "type" field and defaults to CommonJS. - Add "type": "module" to packages/i18n/package.json, matching packages/nimbus and packages/nimbus-mcp. It's an internal build tool only ever invoked via tsx (unaffected by "type") or imported from Vite config loaders, so this is safe. - Add explicit .ts extensions to the now-flagged relative imports in packages/nimbus's vite/vitest configs (allowImportingTsExtensions is already enabled in tsconfig). Verified pnpm test:dev, the unit/unit-isolated/ts-plugin/scripts projects, and typecheck:dev all pass with the warnings gone.
Keeps the unit-testing guideline in sync with the rename in a4c1efb (fix(vitest): silence Vite native configLoader warnings).
The previous commit added "type": "module" to packages/i18n/package.json to silence a Vite native configLoader warning about ESM syntax loaded as CommonJS. That broke this package's build pipeline: its tsx-invoked scripts (build:split, build:compile-strings, build:dictionaries) use CommonJS __dirname without an ESM fallback, and tsx treats a file as ESM once the nearest package.json sets "type": "module". Every script failed with `ReferenceError: __dirname is not defined`, no *.messages.ts files got generated, and packages/nimbus's build then failed with ~36 "Cannot find module '*.messages'" errors. Fix by reverting the package-wide "type": "module" and instead renaming just the offending file to locales.mts (same approach already used for the root-level vitest configs), which makes Vite's native config loader treat it as ESM without touching how tsx resolves every other file in the package. Updated the file's extensionless importers (compile-component-messages.ts, extract-messages.ts, generate-dictionaries.ts, split-by-component.ts) to the explicit .mts extension, since tsx's CJS-mode resolver doesn't probe for .mts on extensionless specifiers. Also updated the one cross-package import in packages/nimbus/vite.config.ts and doc references (packages/i18n/CLAUDE.md, packages/i18n/README.md). Verified: pnpm --filter @commercetools/nimbus-i18n build succeeds, pnpm --filter @commercetools/nimbus build succeeds (the exact command that failed in CI), and the unit/unit-isolated/ts-plugin/nimbus-mcp/ scripts vitest projects all pass (2019 tests).
ByronDWall
force-pushed
the
fix-vitest-native-configloader-warnings
branch
from
August 18, 2026 18:38
aeeac00 to
8c66968
Compare
ByronDWall
enabled auto-merge (squash)
August 18, 2026 18:39
github-actions
Bot
added
the
bundle-sizes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Silences the Vite
configLoader: 'native'deprecation warnings that surfaced when runningpnpm test/pnpm test:dev:No behavior change — purely config/tooling cleanup.
Changes
*.config.tsfiles (andpackages/design-token-ts-plugin/vitest.config.ts) to.mts, since the nearestpackage.jsonhas no"type"field and Node/Vite resolve.tsas CommonJS by default:vitest.config.mtsvitest.dev.config.mtsvitest.scripts.config.mtspackages/design-token-ts-plugin/vitest.config.mtspackage.jsontest:dev/test:storybook:devscripts,projectsarrays, and comments."type": "module"topackages/i18n/package.json, matchingpackages/nimbusandpackages/nimbus-mcp. It's an internal build tool only ever invoked viatsx(unaffected by"type") or imported from a Vite config loader, so this is safe..tsextensions to the now-flagged relative imports inpackages/nimbus's vite/vitest configs (allowImportingTsExtensionsis already enabled intsconfig.json).docs/file-type-guidelines/unit-testing.mdto reference the renamed root orchestrator file.Verification
pnpm test:devand theunit/unit-isolated/ts-plugin/nimbus-mcp/scriptsprojects all pass (1690+ tests), with noconfigLoader: 'native'warnings.pnpm --filter @commercetools/nimbus typecheck:devpasses.Not in scope
plans/full-mcp-ui-workflow/ssr/SSR_IMPLEMENTATION.mdstill references the pre-renamevitest.config.tsfilename — it's a standalone planning doc, not a maintained guideline, so left untouched.docs/file-type-guidelines/unit-testing.md's root-orchestrator example only lists 2 of the now 6 projects — pre-existing drift unrelated to this change, not fixed here.