fix(Init): fix a typo in _ask_version_provider options and remove unnecessary filter #1528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v4-9-0-test #1528 +/- ##
==============================================
Coverage ? 98.09%
==============================================
Files ? 58
Lines ? 2683
Branches ? 0
==============================================
Hits ? 2632
Misses ? 51
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bearomorphism
changed the title
Lee-W
approved these changes
Aug 13, 2025
commitizen/commands/init.py
Outdated
| "uv": "uv: Get and set version from pyproject.toml and uv.lock", | ||
| "scm": "scm: Fetch the version from git and does not need to set it back", | ||
| } | ||
| options = ( |
There was a problem hiding this comment.
Suggested change
| options = ( | |
| # (tool_name, description) | |
| options = ( |
There was a problem hiding this comment.
named tuple might be better but comment works for me as well
There was a problem hiding this comment.
let's do named tuple
There was a problem hiding this comment.
Hi, I added a named tuple for it, please review.
bearomorphism
force-pushed
the
f-init-version-provider
branch
2 times, most recently
from
35677c1 to
1c02970
Compare
Lee-W
reviewed
Aug 13, 2025
commitizen/commands/init.py
Outdated
| @@ -17,6 +17,54 @@ | |||
| from commitizen.version_schemes import KNOWN_SCHEMES, Version, get_version_scheme | |||
|
|
|||
|
|
|||
| class _VersionProviderOption(NamedTuple): | |||
| value: str | |||
There was a problem hiding this comment.
Suggested change
| value: str | |
| provider_name: str |
value is vague
…ecessary filter, use named tuple for options
bearomorphism
force-pushed
the
f-init-version-provider
branch
from
1c02970 to
d966d5f
Compare
Lee-W
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
uvoptionChecklist