Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
=======================================
Coverage 94.78% 94.78%
=======================================
Files 3 3
Lines 728 728
Branches 216 216
=======================================
Hits 690 690
Misses 14 14
Partials 24 24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kinow
left a comment
There was a problem hiding this comment.
I had a first go at reading the paper @Th3nn3ss , great work 👏
I can see the structure you wanted to give to the paper (in the same way you had to structure your presentation, and code for your PR, etc.) and got the idea of what you want to transmit to readers, I think.
You can probably ignore many of my comments, or use it as feedback but not necessarily as the best recommendation since I am not that well versed in academic writing (search for some sites about academic writing, you can probably find some useful information there.)
Cheers
Bruno
kinow
left a comment
There was a problem hiding this comment.
Short and simple. Few comments, but I think this is ready for reviews @Th3nn3ss . Maybe mark as ready for review and ask the others to review it too? Thanks!!!
Co-authored-by: Bruno P. Kinoshita <kinow@users.noreply.github.com>
JOSS paper issue #180