-
-
Notifications
You must be signed in to change notification settings - Fork 233
17054 custom name #1477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
lijiayong
wants to merge
15
commits into
common-workflow-language:main
from
lijiayong:17054-custom-name
Closed
17054 custom name #1477
Changes from 9 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
3c9c0a4
Add formatting for StepNameHint extension
a3ad10b
Change job name according to stepnamehint
lijiayong 55a91d8
Change stepnamehint record
lijiayong 59d60c7
Merge branch 'main' into 17054-custom-name
lijiayong 75c986c
Change how to retrieve stepname from requirements/hints
lijiayong 9833f41
Add unit test for stepname
lijiayong 8abb24c
Change StepNameHint to StepName
lijiayong 662584f
Simplify logic for detecting StepName requirement/hint
lijiayong 7f39f96
Merge remote-tracking branch 'upstream/main' into 17054-custom-name
lijiayong c7a0214
Change StepName to JobName and add docstring to test
lijiayong e4fed7f
Change formatting
lijiayong fd4e699
Fix formatting according to py38-lint
lijiayong d529d3f
Change formatting according to lint
lijiayong a6f5e17
Merge branch 'main' into 17054-custom-name
mr-c 8393482
Merge branch 'main' into 17054-custom-name
mr-c File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
#!/usr/bin/env cwl-runner | ||
cwlVersion: v1.1 | ||
class: CommandLineTool | ||
inputs: | ||
text: | ||
type: string | ||
inputBinding: {} | ||
outputs: [] | ||
baseCommand: echo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
#!/usr/bin/env cwl-runner | ||
$namespaces: | ||
cwltool: "http://commonwl.org/cwltool#" | ||
cwlVersion: v1.1 | ||
class: Workflow | ||
requirements: | ||
ScatterFeatureRequirement: {} | ||
InlineJavascriptRequirement: {} | ||
StepInputExpressionRequirement: {} | ||
|
||
inputs: | ||
texts: | ||
type: string[] | ||
|
||
outputs: [] | ||
|
||
steps: | ||
echo: | ||
run: echo_no_output.cwl | ||
scatter: text | ||
hints: | ||
cwltool:StepName: | ||
stepname: $("test_" + inputs.text.split('.')[0]) | ||
in: | ||
text: texts | ||
out: [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
texts: ["a.vcf", "b.vcf", "c.vcf"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be better to use
stepnameReq is not None
instead