-
-
Notifications
You must be signed in to change notification settings - Fork 63
[WIP] Rust language backend support #917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This commit includes the Python module responsible for generating code based on a given schema. The `schema_salad/rust/salad-core` folder serves as a placeholder for Rust code logic that will enable document (de)serialization, which is still a work in progress due to ongoing code refactoring. The code for this refactoring can be found in the "giuseppe998e/schema_salad" repository branch.
Hello @giuseppe998e ; would you like to have a meeting to discuss how to get this code merged? |
c130c8d
to
31d3fbe
Compare
It is nice to see the progress @giuseppe998e ; let me know if you need help with that mypyc error. Here is a hint: https://mypyc.readthedocs.io/en/latest/native_classes.html#inheritance |
This reverts commit 62162d2. Thats was not the problem. --- Current issue: ``` tests/test_cli_args.py:8: in <module> import schema_salad.main as cli_parser schema_salad/main.py:16: in <module> ??? schema_salad/codegen.py:18: in <module> ??? schema_salad/rust_codegen.py:266: in <module> ??? E AttributeError: attribute '__dict__' of 'type' objects is not writable ```
Hi @mr-c, I was about to reply to your first comment. Sorry for the delay in responding, but at that time, for personal reasons, I was unable to work on the extension until now. Anyway, yes, I'm solving the compatibility issues (or at least I'm trying to)... |
I solved it by completely removing the |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #917 +/- ##
==========================================
- Coverage 83.36% 77.84% -5.52%
==========================================
Files 22 23 +1
Lines 4952 5515 +563
Branches 1185 1278 +93
==========================================
+ Hits 4128 4293 +165
- Misses 547 942 +395
- Partials 277 280 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR brings the Rust language support to
schema-salad-tool
, enabling Rust code generation alongside existing backends.Currently the
salad-core
library (crate), which will handle document (de)serialization, is undergoing a major refactoring. The code will be located in thegiuseppe998e/schema_salad
repository branch.Current Status
This PR is still a draft, and feedback is highly appreciated!