feat: Adding Dockerfile for stats and CI for building container images#24
feat: Adding Dockerfile for stats and CI for building container images#24malteos merged 17 commits intocommoncrawl:masterfrom
Conversation
damian0815
left a comment
There was a problem hiding this comment.
I notice that the background color of the images is transparent - is that intended?
|
The transparent background is coming from the ggplot minimal theme (probably due to a new version) See #23 (comment)
Or tidyverse/ggplot2#4919 (comment) I tried to set the background explicitly but it doesn't work :( |
|
There are still minor differences (font size and colors in url status by year). |
|
Font size, line widths and colors of url status by year are now adjusted. Only |
@sebastian-nagel is this critical or can we just merge this? |
No. It's not critical. |
This PR adds a Dockerfile for the stats workflow including a GitHub action that runs the unit tests, builds the images (stats and site), and pushes the images to the GitHub registry (fix for #20).
The new plots were generated with the container run command from the README but with the image from the feature branch: