Skip to content

feat: Adding filter_cdx and warc_by_cdx commands #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
malteos wants to merge 23 commits into from

adding max file size to aioboto3 implementation; improving test coverage

d9adf03
Select commit
Loading
Failed to load commit list.
Closed

feat: Adding filter_cdx and warc_by_cdx commands #45

adding max file size to aioboto3 implementation; improving test coverage
d9adf03
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 17, 2025 in 1s

63.74% (-31.93%) compared to e5d122a

View this Pull Request on Codecov

63.74% (-31.93%) compared to e5d122a

Details

Codecov Report

❌ Patch coverage is 54.12844% with 350 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.74%. Comparing base (e5d122a) to head (d9adf03).

Files with missing lines Patch % Lines
cdx_toolkit/warcer_by_cdx/aioboto3_warcer.py 12.25% 136 Missing ⚠️
cdx_toolkit/filter_cdx/__init__.py 22.41% 90 Missing ⚠️
cdx_toolkit/warcer_by_cdx/aioboto3_utils.py 45.00% 44 Missing ⚠️
cdx_toolkit/warcer_by_cdx/aioboto3_writer.py 22.72% 34 Missing ⚠️
cdx_toolkit/warcer_by_cdx/cdx_utils.py 57.50% 17 Missing ⚠️
cdx_toolkit/utils.py 75.00% 9 Missing ⚠️
cdx_toolkit/warcer_by_cdx/__init__.py 91.93% 5 Missing ⚠️
cdx_toolkit/warc.py 84.00% 4 Missing ⚠️
cdx_toolkit/warcer_by_cdx/warc_utils.py 88.88% 4 Missing ⚠️
cdx_toolkit/warcer_by_cdx/fsspec_warcer.py 95.83% 3 Missing ⚠️
... and 2 more

❗ There is a different number of reports uploaded between BASE (e5d122a) and HEAD (d9adf03). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (e5d122a) HEAD (d9adf03)
8 7
Additional details and impacted files 
@@             Coverage Diff             @@
##             main      #45       +/-   ##
===========================================
- Coverage   95.66%   63.74%   -31.93%     
===========================================
  Files           7       19       +12     
  Lines         877     1597      +720     
===========================================
+ Hits          839     1018      +179     
- Misses         38      579      +541

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov