fix: correctly fail geocoding jersey postcodes

[joaquimds]

No description provided.

[Copilot]

Pull request overview

This PR fixes a bug in the postcode geocoding functionality where Jersey postcodes (and potentially other postcodes) could return responses from the postcodes.io API with null values for postcode, latitude, or longitude fields, causing the application to crash or behave incorrectly instead of gracefully failing.

Changes:

• Added additional validation checks to ensure postcode, latitude, and longitude fields are not null/falsy before processing
• Added a test case with a Jersey postcode (JE3 2DF) to the test data file to validate the fix

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
src/server/mapping/geocode.ts	Added null/falsy value checks for postcode, latitude, and longitude fields in postcodes.io API response validation
tests/resources/members.csv	Added Notes column and Jersey postcode test case; also added notes to existing test cases

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

There is an extra space after the comma before 'Test Jersey'. This should be 'JE3 2DF,Test Jersey' to be consistent with line 6 where 'BT15 3ES,Test Belfast' has no space after the comma.

[Copilot]

These checks will fail for valid latitude/longitude values of 0. For example, postcodes on the Prime Meridian have longitude 0, and postcodes on the Equator have latitude 0. Consider using explicit null/undefined checks instead: postcodesData.result.latitude == null || postcodesData.result.longitude == null.

Suggested change

	!postcodesData.result.latitude ||
	!postcodesData.result.longitude
	postcodesData.result.latitude == null ||
	postcodesData.result.longitude == null

[Copilot]

The test expectations in tests/feature/importDataSource.test.ts still expect only 5 records (lines 81-171), but adding a 7th row to members.csv means the test will now import 6 records. The test expectations need to be updated to handle the new Jersey postcode record, or the test should explicitly verify that the Jersey record is excluded due to geocoding failure.