Skip to content

Update Privacy Policy Link to GitHub.io#6255

Merged
nicolas-raoul merged 3 commits intocommons-app:mainfrom
sonalyadav1:Move-Privacy-Policy
Mar 19, 2025
Merged

Update Privacy Policy Link to GitHub.io#6255
nicolas-raoul merged 3 commits intocommons-app:mainfrom
sonalyadav1:Move-Privacy-Policy

Conversation

@sonalyadav1
Copy link
Contributor

Description (required)
This PR updates the Privacy Policy link in the app to point to the new URL: https://commons-app.github.io/#privacy-policy.

Fixes #6253

Tests performed (required)

Verified the Privacy Policy link redirects to the new URL.
Tested {Beta Debug} on {VIVO V25} with API level {34}.


fun launchPrivacyPolicy(view: View?) {
Utils.handleWebUrl(this, Uri.parse(BuildConfig.PRIVACY_POLICY_URL))
Utils.handleWebUrl(this, Uri.parse("https://commons-app.github.io/#privacy-policy"))
Copy link
Member

@nicolas-raoul nicolas-raoul Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not modify the value of the PRIVACY_POLICY_URL constant? :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buildConfigField "String", "PRIVACY_POLICY_URL", "\"https://github.com/commons-app/commons-app-documentation/blob/master/android/Privacy-policy.md\"" in app/build.gradle (two places in that file, same value)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, would you mind using the value https://commons-app.github.io/privacy-policy as the URL? (I moved the privacy policy to its own file after all, to increase our chances of passing Google Play inspection by being clearer as a separate page)
Thanks! :-)

@github-actions
Copy link

✅ Generated APK variants!

@sonalyadav1
Copy link
Contributor Author

@nicolas-raoul I've updated the PRIVACY_POLICY_URL in build.gradle and modified the launchPrivacyPolicy function to use BuildConfig.PRIVACY_POLICY_URL.

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙂

@nicolas-raoul nicolas-raoul merged commit 828f69f into commons-app:main Mar 19, 2025
1 check passed
sonalyadav1 added a commit to sonalyadav1/apps-android-commons that referenced this pull request May 22, 2025
* "moved privacy policy"

* Update PRIVACY_POLICY_URL to https://commons-app.github.io/privacy-policy as suggested

* Use BuildConfig.PRIVACY_POLICY_URL in launchPrivacyPolicy function
@sonalyadav1 sonalyadav1 deleted the Move-Privacy-Policy branch June 6, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move privacy policy from GitHub.com to commons-app.github.io

2 participants