Fixes Issue #6241: Explore>Map images show "Unknown"#6260
Merged
nicolas-raoul merged 1 commit intocommons-app:mainfrom Mar 31, 2025
Merged
Fixes Issue #6241: Explore>Map images show "Unknown"#6260nicolas-raoul merged 1 commit intocommons-app:mainfrom
nicolas-raoul merged 1 commit intocommons-app:mainfrom
Conversation
… display the username Before this change, the labels that would appear on the marker when tapped did not include the author or username. Instead, it displayed "Unknown". After this change, the labels now display the author name. If the author name is not available, the username will be displayed. If both are unavailable, the default value of "Unknown" will be displayed. To improve the readability of the text, any HTML text is removed from the username/author.
|
✅ Generated APK variants! |
sonalyadav1
pushed a commit
to sonalyadav1/apps-android-commons
that referenced
this pull request
May 22, 2025
… display the username (commons-app#6260) Before this change, the labels that would appear on the marker when tapped did not include the author or username. Instead, it displayed "Unknown". After this change, the labels now display the author name. If the author name is not available, the username will be displayed. If both are unavailable, the default value of "Unknown" will be displayed. To improve the readability of the text, any HTML text is removed from the username/author.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #6241
What changes did you make and why?
I created a private helper method to locate the specific
Mediaobject from themediaListfield using the image URL retrieved from theBaseMarkerobject.I also added code so that once the correct
Mediaobject is found, the author/username is retrieved and any HTML is removed from it. This String is then placed in the label constructor. When the marker is tapped, the author/username is now displayed in the label (see image).Tests performed (required)
Tested ProdDebug on Android Studio emulator with API level 34.
Screenshots (for UI changes only)