Bump target sdk to API 35 and make the app UI compatible with edge to edge #6393
Conversation
Since the toolbars have primary color as bg, we should make the status bar white
|
Seems like we also need to update the roboelectric version that supports API 35. I'll look for a compatible version and update the PR tomorrow :) |
|
Tested upload/explore/nearby, it works great! |
|
still a draft? |
|
Thanks @nicolas-raoul for testing :) |
It is not easy, I think the only way is to modify the check to trigger it (then revert before committing). Thanks a lot! :-) |
It allows the last item to sits above the navigation bar while preserving edge-to-edge appearance.
Also, refactor LocationPicker and DescriptionEdit activities to use extension functions and reduce duplication
|
✅ Generated APK variants! |
|
Hi, I've been sick since Sunday and haven't been able to focus on the work. I also discovered two different issues while working on this task, and will create them today. Also, the app looks fine on API 29+, but having some issues on API 28 that I'll fix by tomorrow as soon as possible. Sorry for being late with this task. |
|
Hey @rohit9625 please take care and do not feel sorry or worry about being late. We still have some time, so please don't try to overstretch and pull it off while putting your health at stake. Thanks for the draft PR, I'll start going through the changelog to accelerate the review process once this PR gets ready 🙂 |
|
Thank you so much, @RitikaPahwa4444 — your kind words means a lot to me. I’m feeling better now and should be able to resume work and finish the task this week. 🙂 |
Description (required)
Fixes #6362
What changes did you make and why?
I have made most of the activities edge-to-edge compatible, along with ensuring backward compatibility on API < 35.
Tests performed (required)
Tested prodDebug on Samsung A14 with API level 35 and Pixel 6 with API level 34.
Screenshots (for UI changes only)
Will provide the screenshot comparisons once done with edge-to-edge