-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix check scope 6588 #6596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JairoTM-es
wants to merge
6
commits into
commons-app:main
Choose a base branch
from
JairoTM-es:fix-check-scope-6588
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+53
−27
Open
Fix check scope 6588 #6596
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
62df098
Improve PR scope check workflow reliability
JairoTM-es 4c238a5
Improve PR scope check workflow reliability
JairoTM-es c0881d8
Merge branch 'main' into fix-check-scope-6588
RitikaPahwa4444 397aca2
fix(ci): remove unsupported temperature input from ai-inference workflow
JairoTM-es 274c792
test: add unrelated change for scope-check validation
JairoTM-es 01f6b51
test: add unrelated README change to validate scope check
JairoTM-es File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need write access for issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review. The issues: write permission is needed because the workflow posts a comment on the pull request when it detects unrelated changes. Without this permission, the comment step fails with a 403 error and the bot cannot provide guidance to the contributor.
If you prefer to keep permissions more restricted, I can remove the auto-comment step and leave the workflow as a check-only validation.