Skip to content

Improve ctk & qt python packages to avoid segfault when imported from standalone python #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcfr merged 2 commits into from
Mar 15, 2023
Merged

Improve ctk & qt python packages to avoid segfault when imported from standalone python #1072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eaa9200
STYLE: Use consistent indentation in qt/__init__.py.in
jcfr Mar 14, 2023
cbc2c9b
BUG: Avoid segfault if importing qt & ctk python package in standalon…
jcfr Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion Libs/Scripting/Python/Core/Python/ctk/__init__.py.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,21 @@ its namespace."""

__kits_to_load = [ @CTK_PYTHON_WRAPPED_LIBRARIES@ ]

import os
import sys
_standalone_python = "python" in str.lower(os.path.split(sys.executable)[-1])

# Set to True when debugging
_CTK_VERBOSE_IMPORT = False

kits = []
for kit in __kits_to_load:
# Since importing a PythonQt-based module outside of a Qt application
# leads to a segfault, skip the import if it happens in a standalone
# python interpreter.
# See https://github.com/commontk/CTK/pull/520
if _standalone_python:
continue
try:
exec("from CTK%sPythonQt import *" % kit)
kits.append(kit)
Expand Down Expand Up @@ -103,6 +113,6 @@ if _lib == 'Widgets':
decorates_ctkWorkflowWidgetStep_initialize_method()

# Removing things the user shouldn't have to see.
del __kits_to_load, _lib, _CTK_VERBOSE_IMPORT
del __kits_to_load, _lib, _standalone_python, _CTK_VERBOSE_IMPORT
del add_methodclass_to_ctkWorkflowStep_or_ctkWorkflowWidgetStep
del add_methodclass_to_ctkWorkflowWidgetStep, decorates_ctkWorkflowWidgetStep_initialize_method
24 changes: 17 additions & 7 deletions Libs/Scripting/Python/Core/Python/qt/__init__.py.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,28 @@ its namespace."""

__kits_to_load = [ @QT_PYTHON_WRAPPED_LIBRARIES@ ]

import os
import sys
_standalone_python = "python" in str.lower(os.path.split(sys.executable)[-1])

# Set to True when debugging
_CTK_VERBOSE_IMPORT = False

for kit in __kits_to_load:
try:
exec("from PythonQt.Qt%s import *" % kit)
except ImportError as detail:
if _CTK_VERBOSE_IMPORT:
print(detail)
# Since importing a PythonQt-based module outside of a Qt application
# leads to a segfault, skip the import if it happens in a standalone
# python interpreter.
# See https://github.com/commontk/CTK/pull/520
if _standalone_python:
continue
try:
exec("from PythonQt.Qt%s import *" % kit)
except ImportError as detail:
if _CTK_VERBOSE_IMPORT:
print(detail)

if "QObject" not in locals():
if "QObject" not in locals() and not _standalone_python:
from PythonQt.private import QObject

# Removing things the user shouldn't have to see.
del __kits_to_load, _CTK_VERBOSE_IMPORT
del __kits_to_load, _standalone_python, _CTK_VERBOSE_IMPORT