Improve ctk & qt python packages to avoid segfault when imported from standalone python#1072
Merged
jcfr merged 2 commits intocommontk:masterfrom Mar 15, 2023
Merged
Conversation
jcfr
changed the title
jcfr
changed the title
…e python Since importing a PythonQt-based module outside of a Qt application leads to a segfault, skip the import if it happens in a standalone python interpreter. See commontk#520
jcfr
force-pushed
the
improve-ctk-qt-python-to-fix-crash
branch
from
da08630 to
cbc2c9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since importing a PythonQt-based module outside of a Qt application leads to a segfault, skip the import if it happens in a standalone python interpreter.
This issue was discovered while working on the following:
slicertype annotations in static analysis (Sphinx Autodoc and MyPy). Slicer/Slicer#6875Note that we may revisit this once the integration of the following pull-request has been finalized: