Skip to content

BAU: session management fix #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BAU: session management fix #121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions runner/src/server/services/AdapterCacheService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,13 @@ export class AdapterCacheService extends CacheService {
*/
//@ts-ignore
Key(request: HapiRequest, additionalIdentifier?: ADDITIONAL_IDENTIFIER) {
let id = `${request.yar.id}:${request.params.id}`;

let id: string;
if (request.auth && request.auth.credentials && request.auth.credentials.accountId) {
id = `${request.auth.credentials.accountId}:${request.params.id}`;
request.logger.info(`[ACTIVATE-SESSION] get user account id for the session key ${id}`);
} else {
id = `${request.yar.id}:${request.params.id}`;
}
Comment on lines +108 to +114
Copy link
Contributor

@samuelhwilliams samuelhwilliams Jan 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feels like an unrelated change?

edit: ah I thought this PR was just for hot reload fix. This should be two PRs - let's keep separate changes as separate PRs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also - I'm not convinced we do actually need this after some more investigation, see thread in forms tech 👀

Copy link
Collaborator Author

@nuwan-samarasinghe nuwan-samarasinghe Jan 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broke down to 2 pr's #122

if (request.query.form_session_identifier) {
id = `${id}:${request.query.form_session_identifier}`;
}
Expand Down
Loading