Fixing issue whereby user errors lead to response.header is not a function TypeError #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to Sentry error: https://funding-service-design-team-dl.sentry.io/issues/6471426578/?alert_rule_id=15706220&alert_type=issue¬ification_uuid=08b61e1e-1e35-4fac-bad5-01612c95b829&project=4508573162864640&referrer=slack
The server crashes (TypeError: response.header is not a function) when onPreResponse tries modifying headers on non-5xx Boom error objects (e.g., 404s).
This PR changes onPreResponse in index.ts to bypass header modifications for all Boom errors (response.isBoom), preventing calls to the non-existent .header() function on those error objects (see docs). This aligns with the code in the base repo's
index.tswhich also bypasses header modifications in the case of Boom objects.