Skip to content

Conversation

mileshinch
Copy link
Contributor

@mileshinch mileshinch commented Jul 21, 2025

NOT READY YET

Branch name Developed by Reviewed by Link to PR
table-gds-styling Miles Ibrahim Add link to pull request here
XXX Miles Mike (for use in land calculator) no pull request for this
Name Folder Sub-Folder Is new component? Main status change Sub-statuses additions
Table data-vis table False In progress -> baseline completed
Name Description Context
Table No change No change
Component Connected component Change to interaction
Table Button The Table component uses the Button component in the table headers. I added a button type to the Button component which has the style of the Table component and has sorting arrows. I added some css in the Table component to handle interaction with the button's sorting arrows.
Feature Description
Sorting User can sort each column in ascending or descending order
Color scale User can toggle a color scale which colors values within in each column according to their value relative to just that column
Accessibility I've done some work on accessibility but I would like this reviewed
Responsive I've done some work on responsiveness but I would like this reviewed

Additional Notes

There are some issues that appeared after merging Mike's changes and/or the sorting interaction changes Mike and I made during a recent pair programming session. The sorting is temperamental and the colour scale isn't working. I need to have a look at these before anyone reviews. But creating this PR request now as part of the learning exercise during review day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant