Skip to content

Make card link bigger and move inline styling to style tag #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Make card link bigger and move inline styling to style tag #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c65238e
Make card link bigger and move inline styling to style tag
Sep 19, 2025
3f40789
Remove redundant import line
Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 33 additions & 17 deletions src/lib/components/ui/Card.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
<script>
import PostcodeOrAreaSearch from "./PostcodeOrAreaSearch.svelte";

let {
linkCard = true,
linkText = undefined,
linkTextColor = "#1D70B8",
href = undefined,
callToActionBackgroundColor = "white",
bodyText = undefined,
bodyTextColor = undefined,
bodyTextColor = "#0B0C0C",
bodyBackgroundColor = "#FBFCFD",
bodyTopBorderColor = "#F4F8FB",
bodyBottomBorderColor = "#c3d9e9",
Expand All @@ -23,15 +21,13 @@
style="background-color: {callToActionBackgroundColor};"
>
{#if linkCard}
<div
class="link"
style="display: flex; align-items: center; justify-content: space-between;"
>
<span class="govuk-heading-m">
<a {href} class="govuk-link" style="color: {linkTextColor};"
>{linkText}</a
>
</span>
<a class="link" {href}>
<h3
class="govuk-link link-heading govuk-heading-m"
style="--link-text-color: {linkTextColor}"
>
{linkText}
</h3>
<svg
xmlns="http://www.w3.org/2000/svg"
width="10"
Expand All @@ -44,17 +40,19 @@
fill={linkTextColor}
></path>
</svg>
</div>
</a>
{:else}
{@render cardSnippet()}
{/if}
</div>

<div
class="body govuk-body"
style="background-color: {bodyBackgroundColor}; color: {bodyTextColor}; border-bottom: 1px solid {bodyBottomBorderColor}; border-top: 1px solid {bodyTopBorderColor};"
class="body-div"
style="--body-bg-color: {bodyBackgroundColor}; --body-bottom-border-color: {bodyBottomBorderColor}; --body-top-border-color: {bodyTopBorderColor};"
>
{bodyText}
<p class="govuk-body body-text" style="--body-text-color: {bodyTextColor};">
{bodyText}
</p>
</div>
</div>

Expand All @@ -68,11 +66,29 @@
padding: 15px 20px;
}

.body {
.link {
display: flex;
align-items: center;
justify-content: space-between;
width: 100%;
}

.link-heading {
color: var(--link-text-color);
}

.body-div {
background-color: var(--body-bg-color);
border-bottom: 1px solid var(--body-bottom-border-color);
border-top: 1px solid var(--body-top-border-color);
padding: 10px 20px 15px 20px;
flex: 1;
}

.body-text {
color: var(--body-text-color);
}

.govuk-heading-m {
/* overwriting margin and line-height to make link centered vertically */
margin: 0;
Expand Down
4 changes: 2 additions & 2 deletions src/wrappers/components/ui/CardWrapper.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,12 +189,12 @@
{
name: "bodyText",
category: "Input props",
value: `This is the text that gives more information about call to action in the card heading test.`,
value: `This is the text that gives more information about the call to action in the card heading.`,
},
{
name: "bodyTextColor",
category: "Input props",
value: ``,
value: `#0B0C0C`,
},
{
name: "bodyBackgroundColor",
Expand Down