feat: Add card/list view toggle with enhanced list view #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ViewToggle component with grid/list icons and active state styling - Create ScriptCardList component with horizontal layout design - Add view-mode API endpoint for GET/POST operations to persist view preference - Update ScriptsGrid and DownloadedScriptsTab with view mode state and conditional rendering - Enhance list view with additional information: - Categories with tag icon - Creation date with calendar icon - OS and version with computer icon - Default port with terminal icon - Script ID with info icon - View preference persists across page reloads - Same view mode applies to both Available and Downloaded scripts pages - List view shows same information as card view but in compact horizontal layout
- Fix unsafe argument type errors in view mode loading - Use proper type guards for viewMode validation - Replace logical OR with nullish coalescing operator - Add explicit type casting for API response validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a view toggle feature that allows users to switch between card view (default) and list view on both the Available Scripts and Downloaded Scripts pages.
Features Added
Technical Implementation
ViewToggle.tsxcomponent with active state stylingScriptCardList.tsxcomponent with horizontal layout design/api/settings/view-modeendpoint following existing settings patternScriptCardinterface to include OS, version, and port informationgetScriptCardsWithCategoriesAPI to provide additional metadataScriptsGrid.tsxandDownloadedScriptsTab.tsxwith conditional renderingUser Experience
Files Changed
src/app/_components/ViewToggle.tsx(new)src/app/_components/ScriptCardList.tsx(new)src/app/api/settings/view-mode/route.ts(new)src/app/_components/ScriptsGrid.tsx(modified)src/app/_components/DownloadedScriptsTab.tsx(modified)src/server/api/routers/scripts.ts(modified)src/types/script.ts(modified)Testing