Skip to content

Conversation

@michelroegl-brunner
Copy link
Member

Overview

This PR implements automatic server selection when only one server is configured and removes the local execution option entirely.

Changes Made

✨ New Features

  • Auto-select single server: When exactly one server is configured, the execution modal is bypassed and the script runs immediately
  • Server settings integration: Added button to open server settings directly from execution modal when no servers are configured
  • Auto-refresh: Server list automatically refreshes when settings modal closes

🔧 Improvements

  • Removed local execution: All scripts now execute via SSH only, simplifying the execution flow
  • Updated modal title: Changed from 'Execution Mode' to 'Select Server' to better reflect functionality
  • Streamlined UI: Removed execution mode selection, focusing only on server selection

🐛 Bug Fixes

  • Cleaned up debug messages that were appearing in terminal output

Behavior Changes

  • 0 servers: Modal shows with message that servers are required + 'Open Server Settings' button
  • 1 server: Modal is skipped entirely, script immediately starts on that server via SSH
  • 2+ servers: Modal shows with server selection dropdown, user selects which server to use

Testing

  • Single server setup - auto-execution works
  • Multiple servers - manual selection works
  • No servers - settings button appears
  • Settings integration - server list refreshes after adding servers

This provides a much smoother user experience, especially for single-server setups, while maintaining full functionality for multi-server environments.

- Remove local execution option entirely, all scripts now execute via SSH
- Auto-select and skip modal when exactly one server is configured
- Add server settings button when no servers are configured
- Auto-refresh server list when settings modal closes
- Update modal title from 'Execution Mode' to 'Select Server'
- Remove console.log for WebSocket messages in Terminal component
- Remove debug output from SSH command execution in installedScripts router
- Clean up command output chunk logging and config data logging
- Remove container check result debug messages
- This eliminates unwanted debug messages appearing in terminal output
@michelroegl-brunner michelroegl-brunner requested a review from a team as a code owner October 10, 2025 11:21
@michelroegl-brunner michelroegl-brunner self-assigned this Oct 10, 2025
@michelroegl-brunner michelroegl-brunner merged commit aa9e155 into main Oct 10, 2025
4 checks passed
@michelroegl-brunner michelroegl-brunner deleted the feat/simplify_ssh_execution branch October 14, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants