Skip to content

Conversation

@michelroegl-brunner
Copy link
Member

Summary

This PR adds a confirmation modal before script execution when only one server is saved, and implements alphabetical sorting of servers by name.

Changes

Confirmation Modal

  • Single Server: Shows confirmation modal with script name and server details
  • Multiple Servers: Preserves existing behavior with server selection dropdown
  • Auto-selection: Single server is auto-selected but requires user confirmation
  • No Auto-execution: Removed immediate execution when only one server exists

Server Sorting

  • Alphabetical Order: Servers are now sorted by name (PROX2 before PROX3)
  • Consistent Sorting: Applied across all components (dropdown, settings modal, confirmation modal)
  • Safe Sorting: Uses nullish coalescing operators for proper handling of undefined names

Technical Details

  • Modified to show confirmation UI for single server scenario
  • Updated and with server sorting
  • Fixed ESLint issues with nullish coalescing operators
  • Maintained SSH mode as the only execution method

Testing

  • ✅ Build passes successfully
  • ✅ No linting errors
  • ✅ TypeScript compilation successful
  • ✅ Confirmation modal displays correctly for single server
  • ✅ Server sorting works in all components

Screenshots

Single Server Confirmation:

  • Shows script name prominently
  • Displays server details (name, IP) in styled card
  • "Install" and "Cancel" buttons

Multiple Servers:

  • Server selection dropdown with no pre-selection
  • "Run on Server" button (disabled until selection)

Fixes the issue where PROX3 appeared before PROX2 in server lists.

- Add confirmation modal when only one server is saved
- Show script name and server details in confirmation view
- Auto-select single server but require user confirmation
- Preserve existing behavior for multiple servers (no pre-selection)
- Sort servers alphabetically by name in all components
- Fix ESLint issues with nullish coalescing operators

Fixes: PROX2 now appears before PROX3 in server lists
@michelroegl-brunner michelroegl-brunner requested a review from a team as a code owner October 10, 2025 12:36
@michelroegl-brunner michelroegl-brunner merged commit e63958e into main Oct 10, 2025
4 checks passed
@michelroegl-brunner michelroegl-brunner deleted the fix/script_execution branch October 14, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants