Fix: Detect downloaded scripts from all directories (ct, tools, vm) #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add getAllDownloadedScripts() method to scan all script directories - Update DownloadedScriptsTab to use new API endpoint - Update ScriptsGrid to use new API endpoint for download status detection - Update main page script counts to use new API endpoint - Add recursive directory scanning to handle subdirectories - Maintain backward compatibility with existing getCtScripts endpoint Fixes issue where scripts downloaded to tools/, vm/, or vw/ directories were not showing in Downloaded Scripts tab or showing correct download status in Available Scripts tab.
CrazyWolf13
approved these changes
Oct 13, 2025
- Remove redundant string type annotation from relativePath parameter - Fix getScriptsFromDirectory method call to match updated signature
michelroegl-brunner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Scripts downloaded to directories other than
scripts/ct/were not being detected and shown in the Downloaded Scripts tab. The Available Scripts tab also showed incorrect download status for scripts intools/,vm/, andvw/directories.Solution
getAllDownloadedScripts()method toScriptManagerclass that scans all script directories (ct, tools, vm, vw)tools/pve/DownloadedScriptsTabto use the new API endpointScriptsGridto use the new API endpoint for download status detectiongetCtScriptsendpointChanges
src/server/lib/scripts.ts: AddedgetAllDownloadedScripts()and recursivegetScriptsFromDirectory()methodssrc/server/api/routers/scripts.ts: AddedgetAllDownloadedScriptsAPI endpointsrc/app/page.tsx: Updated to use new API for script countssrc/app/_components/DownloadedScriptsTab.tsx: Updated to use new API endpointsrc/app/_components/ScriptsGrid.tsx: Updated to use new API endpointTesting
Fixes the issue where scripts downloaded to non-ct directories were not properly tracked or displayed.