Skip to content

Conversation

@michelroegl-brunner
Copy link
Member

Summary

This PR fixes several SSH key handling issues and improves the public key modal user experience.

Changes Made

🔧 SSH Key Import Fixes

  • Auto-trim whitespace: SSH keys now automatically have trailing whitespace and empty lines removed when pasted or uploaded
  • Prevents import failures: No more manual editing required to remove extra whitespace

🔧 Public Key Modal Improvements

  • Reduced textarea size: Public key textarea reduced from 120px to 60px min-height for better space usage
  • Quick command section: Added pre-filled echo command for adding keys to authorized_keys
  • One-click copy: Users can copy either just the key or the complete command
  • Better UX: Clear separation between key display and command sections

🔧 ServerForm Enhancements

  • View Public Key button: Added button in ServerForm for generated key pairs (works before saving server)
  • Immediate access: Users can view public keys right after generation

Technical Details

  • Modified to auto-trim whitespace in both paste and file upload handlers
  • Enhanced with smaller textarea and quick command functionality
  • Updated to include View Public Key button for generated keys
  • All changes maintain existing functionality while improving user experience

Testing

  • ✅ Build successful with no errors
  • ✅ All linting checks pass
  • ✅ No breaking changes to existing functionality

User Benefits

  • Faster SSH key setup with fewer manual steps
  • Reduced errors from whitespace issues
  • Better modal layout and usability
  • One-click access to public keys and commands

- Changed IP input field width from w-32 (128px) to w-40 (160px)
- Fixes truncation issue for IP addresses in format 123.123.123.123
- Affects Web UI column in desktop table view when editing scripts
- Fix SSH key import to automatically trim trailing whitespace and empty lines
- Add 'View Public Key' button in ServerForm for generated key pairs
- Reduce public key textarea size from 120px to 60px min-height
- Add quick command section with pre-filled echo command for authorized_keys
- Improve user experience with one-click copy functionality for both key and command
@michelroegl-brunner michelroegl-brunner requested a review from a team as a code owner October 17, 2025 11:43
This was linked to issues Oct 17, 2025
@michelroegl-brunner michelroegl-brunner merged commit 16e918e into main Oct 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

box sizing of ip + port box SSH Key 25519 again

2 participants