Skip to content

Conversation

@michelroegl-brunner
Copy link
Member

🐛 Bug Fix

Problem

The Container ID display was not showing after the whiptail input dialog, regardless of whether the user entered a custom ID or left it empty.

Root Cause

The echo statement was inside the whiptail output capture block where the output redirection was interfering with the display.

Solution

  • Moved the echo statement outside the whiptail output capture block
  • Consolidated duplicate echo statements into a single display
  • Ensured Container ID is properly displayed after whiptail dialog completion

Changes

  • File:
  • Lines: 442-449
  • Impact: Container ID now displays correctly in the build process

Testing

  • ✅ Container ID displays when user enters custom ID
  • ✅ Container ID displays when user leaves field empty (uses default)
  • ✅ No duplicate echo statements
  • ✅ Consistent with other similar sections (hostname, etc.)

Feature Flag

This fix is ready for immediate deployment and does not require a feature flag as it's a bug fix that improves existing functionality.


Type: Bug Fix
Priority: Medium
Breaking Changes: None

- Move echo statement outside whiptail output capture block
- Fix output redirection interference with Container ID display
- Ensure Container ID is properly displayed regardless of user input
- Consolidate duplicate echo statements into single display
@michelroegl-brunner michelroegl-brunner requested a review from a team as a code owner October 24, 2025 07:19
@michelroegl-brunner michelroegl-brunner changed the title fix: Container ID display not showing after whiptail input fix: Container ID display not showing after whiptail input and update tools.func Oct 24, 2025
@michelroegl-brunner michelroegl-brunner linked an issue Oct 24, 2025 that may be closed by this pull request
@michelroegl-brunner michelroegl-brunner merged commit 86f5506 into main Oct 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect Container ID listed on "Installed Scripts" page

2 participants