Skip to content

Conversation

@tremor021
Copy link
Member

✍️ Description

  • Moved to use helper functions
  • Code cleanup

🔗 Related PR / Issue

Link: #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

@tremor021 tremor021 requested a review from a team as a code owner July 5, 2025 17:26
@tremor021 tremor021 self-assigned this Jul 5, 2025
@github-actions github-actions bot added refactor update script A change that updates a script labels Jul 5, 2025
@michelroegl-brunner michelroegl-brunner merged commit e140631 into community-scripts:main Jul 5, 2025
2 checks passed
@JeffBusch
Copy link

Getting this error:

⠴ Installing Dependencies (Patience)0: line 19: make: command not found
⠦ Installing Dependencies (Patience)
[ERROR] in line 19: exit code 0: while executing command make

I think the "make" in the script should be indented?

@tremor021
Copy link
Member Author

Its missing a backslash in the dependency section, pushing a PR to fix it

@tremor021 tremor021 deleted the bookstack branch July 9, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor update script A change that updates a script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants