Skip to content

Conversation

@MickLesk
Copy link
Member

@MickLesk MickLesk commented Jul 9, 2025

✍️ Description

full refactor of stirling-pdf
now missing tools are available too (new unoserver service)

=> For all old users, its better to recreate the LXC

Edit, build an check for old installs with exit, so users need to recreate.
if [[ ! -f /etc/systemd/system/unoserver.service ]]; then
msg_custom "⚠️ " "\e[33m" "Legacy installation detected – please recreate the container using the latest install script."
exit 0
fi

🔗 Related PR / Issue

Link: #5816

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

@MickLesk MickLesk requested a review from a team as a code owner July 9, 2025 12:55
@github-actions github-actions bot added breaking change A change that is not backward compatible refactor update script A change that updates a script labels Jul 9, 2025
tremor021
tremor021 previously approved these changes Jul 9, 2025
@MickLesk
Copy link
Member Author

MickLesk commented Jul 9, 2025

Edit, build an check for old installs with exit, so users need to recreate.

if [[ ! -f /etc/systemd/system/unoserver.service ]]; then
msg_custom "⚠️ " "\e[33m" "Legacy installation detected – please recreate the container using the latest install script."
exit 0
fi

@MickLesk MickLesk requested a review from a team as a code owner July 9, 2025 13:05
@github-actions github-actions bot added the json label Jul 9, 2025
@michelroegl-brunner michelroegl-brunner merged commit 7b38025 into main Jul 9, 2025
4 checks passed
@MickLesk MickLesk deleted the ref_stirlingpdf branch July 21, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change A change that is not backward compatible json refactor update script A change that updates a script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants