Skip to content

Conversation

@MickLesk
Copy link
Member

@MickLesk MickLesk commented Jul 9, 2025

✍️ Description

  • Refactor
  • Adding Features:
    1. Install Compose v2 Plugin
    1. Portainer
    1. Portainer Agent (only if Portainer not installed)
    1. Expose Docker TCP Socket - Local, No, All Interfaces
  • Update-Script Refactor - autom. Crawling if Portainer / Agent Installed / Docker V2 Installed -> Update this
image image

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

@github-actions github-actions bot added feature update script A change that updates a script labels Jul 9, 2025
@MickLesk MickLesk marked this pull request as ready for review July 11, 2025 08:10
@MickLesk MickLesk requested a review from a team as a code owner July 11, 2025 08:10
@MickLesk MickLesk changed the title Refactor & Function Push: Docker Refactor & Function Bump: Docker Jul 11, 2025
@CrazyWolf13 CrazyWolf13 merged commit 3ca5306 into main Jul 11, 2025
4 checks passed
@CrazyWolf13 CrazyWolf13 deleted the docker_ref branch July 11, 2025 09:39
@Ivoz
Copy link

Ivoz commented Nov 5, 2025

Hi @MickLesk , I was reading this change, and I noticed. The install script runs $STD sh <(curl -fsSL https://get.docker.com). Docker's install script, by default, already installs the docker-compose-plugin package, which comes from docker's sources, not debian's. I'd assume, coming from docker's sources, it would already be relatively up-to-date and compatible with the rest of the docker stack installed. For instance, I just installed this package on a new Trixie install on an RPi; docker-compose-plugin shows to be 2.40.3, which is the same as the current release in https://github.com/docker/compose/releases

So I'd postulate that maybe one doesn't need to manually re-install any other docker compose plugin as the script currently does (unless the get.docker.com sh file changes drastically in the future)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature update script A change that updates a script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants