Skip to content

core: sanitize appname for certificate generation #9552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CrazyWolf13 merged 3 commits into from
Dec 1, 2025
Merged

core: sanitize appname for certificate generation #9552

CrazyWolf13 merged 3 commits into from
Dec 1, 2025

Conversation

@tremor021
Copy link
Member

@tremor021 tremor021 commented Dec 1, 2025

✍️ Description

  • Fixed certificate path

🔗 Related PR / Issue

Link: #9550

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

@tremor021 tremor021 self-assigned this Dec 1, 2025
@tremor021 tremor021 requested a review from a team as a code owner December 1, 2025 18:36
@tremor021 tremor021 linked an issue Dec 1, 2025 that may be closed by this pull request
ActualBudget Fails to start after install #9550
Closed
2 tasks
@github-actions github-actions bot added bugfix update script A change that updates a script labels Dec 1, 2025
@MickLesk
Copy link
Member

MickLesk commented Dec 1, 2025

Isnt better to Format the appname Like the fetch deploy func?

local app_lc=$(echo "${app,,}" | tr -d ' ')

@tremor021
Copy link
Member Author

tremor021 commented Dec 1, 2025

Its your refactor that introduced this.

CrazyWolf13
CrazyWolf13 previously approved these changes Dec 1, 2025
View reviewed changes
@MickLesk
Copy link
Member

MickLesk commented Dec 1, 2025

???

@github-actions github-actions bot added the core label Dec 1, 2025
@MickLesk MickLesk changed the title Actual Budget: Fix certificate path core: sanitize appname for certificate generation Dec 1, 2025
@MickLesk MickLesk removed the core label Dec 1, 2025
@CrazyWolf13 CrazyWolf13 merged commit e5cc0a4 into main Dec 1, 2025
2 checks passed
@tremor021 tremor021 deleted the tremor021-patch-2 branch December 1, 2025 21:41
probers1 pushed a commit to probers1/ProxmoxVE that referenced this pull request Dec 5, 2025
@tremor021 @MickLesk @probers1
core: sanitize appname for certificate generation (community-scripts#…
0cc01ec 
…9552)

* Update SSL key and certificate paths for Actual Budget

* Use lowercase app name for certificate paths

* revert changes at actualbudget

---------

Co-authored-by: CanbiZ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MickLesk MickLesk MickLesk approved these changes

@CrazyWolf13 CrazyWolf13 CrazyWolf13 approved these changes

Assignees

@tremor021 tremor021

Labels

bugfix update script A change that updates a script

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ActualBudget Fails to start after install

4 participants

@tremor021 @MickLesk @CrazyWolf13