Skip to content

Add auth via requirepass to Valkey #9570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MickLesk merged 6 commits into from
Dec 2, 2025
Merged

Add auth via requirepass to Valkey #9570

MickLesk merged 6 commits into from
Dec 2, 2025

Conversation

@pshankinclarke
Copy link
Contributor

@pshankinclarke pshankinclarke commented Dec 2, 2025

✍️ Description

On firstboot, the container auto-configures a random password via requirepass; the password is stored in /root/.valkey_pass.txt inside the container.

🔗 Related PR / Issue

Link: # Discussion #3446

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

@pshankinclarke pshankinclarke requested review from a team as code owners December 2, 2025 00:42
@github-actions github-actions bot added json update script A change that updates a script labels Dec 2, 2025
MickLesk
MickLesk previously approved these changes Dec 2, 2025
View reviewed changes
CrazyWolf13
CrazyWolf13 requested changes Dec 2, 2025
View reviewed changes
@MickLesk
Refactor notes in valkey.json for clarity
49160d2 
Updated notes structure to include detailed login instructions.
@MickLesk
Remove password saving message from installation script
5e9e4c3 
Removed message indicating Valkey password saving.
CrazyWolf13
CrazyWolf13 requested changes Dec 2, 2025
View reviewed changes
MickLesk
MickLesk previously approved these changes Dec 2, 2025
View reviewed changes
@CrazyWolf13 CrazyWolf13 self-requested a review December 2, 2025 08:49
@MickLesk MickLesk merged commit 327cb37 into community-scripts:main Dec 2, 2025
3 checks passed
@pshankinclarke pshankinclarke deleted the valkey-auth branch December 2, 2025 15:53
probers1 pushed a commit to probers1/ProxmoxVE that referenced this pull request Dec 5, 2025
@pshankinclarke @MickLesk
@CrazyWolf13 @probers1
Add auth via requirepass to Valkey (community-scripts#9570)
863c2cc 
* Add auth via requirepass to Valkey

* Refactor notes in valkey.json for clarity

Updated notes structure to include detailed login instructions.

* Remove password saving message from installation script

Removed message indicating Valkey password saving.

* Fix JSON syntax error in valkey.json

* Update valkey.json

* refactor

---------

Co-authored-by: CanbiZ <[email protected]>
Co-authored-by: Tobias <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MickLesk MickLesk MickLesk approved these changes

@CrazyWolf13 CrazyWolf13 CrazyWolf13 approved these changes

Assignees

No one assigned

Labels

feature json update script A change that updates a script

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pshankinclarke @MickLesk @CrazyWolf13