Skip to content

Conversation

@MickLesk
Copy link
Member

@MickLesk MickLesk commented Dec 7, 2025

✍️ Description

The stop_all_services function failed when grep found no matching services, causing exit code 1 in pipefail mode.
Changed to capture grep output with || true fallback and only process if services were found.

Fixes #9741

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

The stop_all_services function failed when grep found no matching
services, causing exit code 1 in pipefail mode.

Changed to capture grep output with || true fallback and only
process if services were found.

Fixes #9741 (Baikal update error)
@MickLesk MickLesk requested a review from a team as a code owner December 7, 2025 18:03
@michelroegl-brunner michelroegl-brunner merged commit ba5bdd9 into main Dec 7, 2025
1 check passed
@MickLesk MickLesk deleted the fix/baikal-update-9741 branch December 8, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Baikal update error

4 participants