Add golink LXC #906

SimplyMinimal · 2025-09-18T03:52:51Z

🛑 New scripts must first be submitted to ProxmoxVED for testing.
PRs for new scripts that skip this process will be closed.

✍️ Description

Added golink from Tailscale as LXC container

🔗 Related PR / Issue

Link: #N/A

✅ Prerequisites (X in brackets)

Self-review completed – Code follows project standards.
Tested thoroughly – Changes work as expected.
No breaking changes – Existing functionality remains intact.
No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

🐞 Bug fix – Resolves an issue without breaking functionality.
✨ New feature – Adds new, non-breaking functionality.
💥 Breaking change – Alters existing functionality in a way that may require updates.
🆕 New script – A fully functional and tested script or script set.
🌍 Website update – Changes to website-related JSON files or metadata.
🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

Follows Code_Audit.md & CONTRIBUTING.md guidelines
Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
No hardcoded credentials

📋 Additional Information (optional)

tremor021 · 2025-09-18T06:58:52Z

We don't use git pull to deploy releases. If the application has no releases on github, then we opt out of making a script for it.

git pull way of deploying app is very risky as you will pull possibly unstable code and this would result in people possibly losing their data or w/e.

SimplyMinimal · 2025-09-18T13:22:13Z

Hi @tremor021,

Usually I would agree to stick with tagged releases but the codebase that the script pulls from is maintained by Tailscale themselves so there's a high degree of confidence that the main branch will be stable.

Setting it up this way allows the go build system to build the latest version on each run straight from the source which would be more trusted/open than relying on a pre-built binary.

CrazyWolf13 · 2025-09-18T13:35:41Z

@SimplyMinimal No matter what Compandy is behind it, we don't do git pull, only latest tagged release via our fetch_and_deploy_gh_release func.

CrazyWolf13 · 2025-09-18T13:36:26Z

install/golink-install.sh

+setup_go
+
+msg_info "Cloning Golink Repository"
+$STD git clone https://github.com/tailscale/golink.git /opt/golink


I've swapped it with a curl to a tagged release instead.

tremor021 · 2025-09-18T14:09:32Z

Hi @tremor021,

Usually I would agree to stick with tagged releases but the codebase that the script pulls from is maintained by Tailscale themselves so there's a high degree of confidence that the main branch will be stable.

Setting it up this way allows the go build system to build the latest version on each run straight from the source which would be more trusted/open than relying on a pre-built binary.

@SimplyMinimal the point i'm making is that we need to have something to "latch" on as we deploy this. We decided that it would be a tagged release. Pulling code from a "live" repo is risky, no matter whos maintaining it.
A repo without a release system can break every second, while release system solves that. If a release breaks we can just pin the working release in our scripts until the fix for the broken one is released. You cant really do that with a like "git pull" and we dont want to make workarounds

CrazyWolf13 · 2025-09-18T17:04:43Z

@SimplyMinimal I saw they have a 1.0.0 Tag, you should be able to use that.

SimplyMinimal · 2025-09-18T19:47:33Z

I attempted to use variations of fetch_and_deploy_gh_release but it's unable to locate the tags as it's not actually a release. Just a tag.

Do you have any suggestions on how to best pull the tarball? Is using curl to fetch the tagged archive ok or does it need to be within the fetch_and_deploy_gh_release function?

For clarity, here is the last example I've tried:
fetch_and_deploy_gh_release "golink" "tailscale/golink"

Error:

curl: (22) The requested URL returned error: 404
curl: (22) The requested URL returned error: 404
curl: (22) The requested URL returned error: 404
   ✖️   Failed to fetch release metadata from https://api.github.com/repos/tailscale/golink/releases/tags/1.0.0 after 3 attempts

MickLesk · 2025-09-19T07:27:31Z

In the meantime, I would postpone the PR. If necessary, release the correct tarballs. Then the problem will be solved.

tailscale/golink#199

ct/golink.sh

frontend/public/json/golink.json

CrazyWolf13

some things to match our standards, thanks!

CrazyWolf13 · 2025-10-11T18:06:43Z

install/golink-install.sh

+cd /opt/golink || exit
+$STD go mod tidy
+
+# Clean Go cache before building to save space


CrazyWolf13 · 2025-10-11T18:06:48Z

install/golink-install.sh

+# Clean Go cache before building to save space
+$STD go clean -cache -modcache
+
+# Build with optimizations to reduce space usage


CrazyWolf13 · 2025-10-11T18:06:53Z

install/golink-install.sh

+
+# Clean Go cache before building to save space
+$STD go clean -cache -modcache
+


CrazyWolf13 · 2025-10-11T18:06:58Z

install/golink-install.sh

+msg_info "Building Golink"
+cd /opt/golink || exit
+$STD go mod tidy
+


CrazyWolf13 · 2025-10-11T18:07:11Z

install/golink-install.sh

+
+# Clean up build artifacts


CrazyWolf13 · 2025-10-11T18:13:11Z

ct/golink.sh

+    systemctl stop golink
+    msg_ok "Stopped $APP"
+
+    msg_info "Updating $APP"


don't use a var here

Just asking as a learning experience here as this is my first contribution to this project. Based on the other scripts in the repo, almost all of them makes use of the $APP variable which makes sense. You'd have one single place to update the app name across the whole script and it makes it more obvious for readability.

I see several comments here not to use the $APP variable and suggests instead to hardcode the app name. Could I ask why?

It's something we have started doing recently, there were some using a var some without, to make it easier to read and more simple to debug we chose to rather not use a var here as it doesn't really add any value here. More stylistic we know, but this ensures all scripts are line.

CrazyWolf13 · 2025-10-11T18:13:16Z

ct/golink.sh

+    chmod +x golink
+    RELEASE=$(git describe --tags --always 2>/dev/null || echo "main-$(git rev-parse --short HEAD)")
+    echo "${RELEASE}" >/opt/${APP}_version.txt
+    msg_ok "Updated $APP to ${RELEASE}"


CrazyWolf13 · 2025-10-11T18:13:30Z

ct/golink.sh

+    echo "${RELEASE}" >/opt/${APP}_version.txt
+    msg_ok "Updated $APP to ${RELEASE}"
+
+    msg_info "Starting $APP"


Suggested change

msg_info "Starting $APP"

msg_info "Starting Service"

CrazyWolf13 · 2025-10-11T18:13:38Z

ct/golink.sh

+
+    msg_info "Starting $APP"
+    systemctl start golink
+    msg_ok "Started $APP"


CrazyWolf13 · 2025-10-11T18:13:44Z

ct/golink.sh

+    msg_ok "Started $APP"
+    msg_ok "Update Successful"
+  else
+    msg_ok "No update required. ${APP} is already up to date"


Add golink LXC

77485b9

SimplyMinimal requested review from a team as code owners September 18, 2025 03:52

github-actions bot added new script website labels Sep 18, 2025

Point golink ct to use development build.func

be95777

CrazyWolf13 requested changes Sep 18, 2025

View reviewed changes

Use curl to get tagged tar.gz archive of golink

d13aaa2

MickLesk mentioned this pull request Sep 19, 2025

Feature Request: Publish Official GitHub Releases tailscale/golink#199

Open

MickLesk added the awaiting external label Sep 19, 2025

CrazyWolf13 requested changes Oct 9, 2025

View reviewed changes

ct/golink.sh Outdated Show resolved Hide resolved

Use Debian 13

5d43941

CrazyWolf13 requested changes Oct 11, 2025

View reviewed changes

frontend/public/json/golink.json Outdated Show resolved Hide resolved

CrazyWolf13 requested changes Oct 11, 2025

View reviewed changes

SimplyMinimal added 2 commits October 11, 2025 20:49

Debian 13 for golink

1166770

Merge branch 'community-scripts:main' into main

54723fe


		# Clean Go cache before building to save space
		$STD go clean -cache -modcache

Uh oh!

Uh oh!

Add golink LXC #906

Are you sure you want to change the base?

Add golink LXC #906

Uh oh!

Conversation

SimplyMinimal commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✍️ Description

🔗 Related PR / Issue

✅ Prerequisites (X in brackets)

🛠️ Type of Change (X in brackets)

🔍 Code & Security Review (X in brackets)

📋 Additional Information (optional)

Uh oh!

tremor021 commented Sep 18, 2025

Uh oh!

SimplyMinimal commented Sep 18, 2025

Uh oh!

CrazyWolf13 commented Sep 18, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tremor021 commented Sep 18, 2025

Uh oh!

CrazyWolf13 commented Sep 18, 2025

Uh oh!

SimplyMinimal commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MickLesk commented Sep 19, 2025

Uh oh!

Uh oh!

Uh oh!

CrazyWolf13 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

SimplyMinimal commented Sep 18, 2025 •

edited

Loading

SimplyMinimal commented Sep 18, 2025 •

edited

Loading