Skip to content

Conversation

@omernaveedxyz
Copy link

@omernaveedxyz omernaveedxyz commented Sep 25, 2025

🛑 New scripts must first be submitted to ProxmoxVED for testing.
PRs for new scripts that skip this process will be closed.


✍️ Description

🔗 Related PR / Issue

Link: community-scripts/ProxmoxVE#5166

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

  • Follows Code_Audit.md & CONTRIBUTING.md guidelines
  • Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
  • No hardcoded credentials

📋 Additional Information (optional)

The only hard-coded value is the default admin user password is set to changeme. Once logged in, the user can change the password in the UI. Admin user password is now generated.

Copilot AI review requested due to automatic review settings September 25, 2025 04:51
@omernaveedxyz omernaveedxyz requested review from a team as code owners September 25, 2025 04:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Miniflux script to the ProxmoxVE community scripts collection. Miniflux is a minimalist RSS feed reader application.

  • Adds installation script for Miniflux with PostgreSQL database setup
  • Creates container configuration and metadata files
  • Includes update functionality and ASCII art header

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
install/miniflux-install.sh Main installation script that sets up PostgreSQL, installs Miniflux, and configures the service
frontend/public/json/miniflux.json Metadata configuration defining container resources, interface port, and default credentials
ct/miniflux.sh Container creation script with update functionality and initialization logic
ct/headers/miniflux ASCII art header for the Miniflux application

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

This will get auto-generated by our func
- run `apt update` before `apt upgrade miniflux`
- use selfh.st/icons for logo
- remove `[trusted=yes]` from miniflux source
- remove extra spaces
- change `apt-get` to `apt`
Move Miniflux database credentials from a separate file, to directly inside of the `/etc/minflux.conf` file.
@omernaveedxyz omernaveedxyz force-pushed the main branch 2 times, most recently from 3875e8d to e1ac979 Compare October 1, 2025 02:56
@CrazyWolf13
Copy link
Member

Some small things otherwise looks good to me

@michelroegl-brunner
Copy link
Member

@omernaveedxyz Reping, i keep it open for another two days, when nothing happens this will get closed.

@omernaveedxyz
Copy link
Author

Apologies for the delay. I was away on vacation last week and did not have access to my device for testing. I've made the recommended changes to the scripts and tested them on my personal machine. Please let me know if there are any concerns.

Copy link
Member

@CrazyWolf13 CrazyWolf13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last thing, otherwise looks good to me ^^

@phof phof mentioned this pull request Oct 23, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants