-
-
Couldn't load subscription status.
- Fork 126
Add Miniflux script #935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Miniflux script #935
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new Miniflux script to the ProxmoxVE community scripts collection. Miniflux is a minimalist RSS feed reader application.
- Adds installation script for Miniflux with PostgreSQL database setup
- Creates container configuration and metadata files
- Includes update functionality and ASCII art header
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| install/miniflux-install.sh | Main installation script that sets up PostgreSQL, installs Miniflux, and configures the service |
| frontend/public/json/miniflux.json | Metadata configuration defining container resources, interface port, and default credentials |
| ct/miniflux.sh | Container creation script with update functionality and initialization logic |
| ct/headers/miniflux | ASCII art header for the Miniflux application |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This will get auto-generated by our func
- run `apt update` before `apt upgrade miniflux` - use selfh.st/icons for logo - remove `[trusted=yes]` from miniflux source - remove extra spaces - change `apt-get` to `apt`
Move Miniflux database credentials from a separate file, to directly inside of the `/etc/minflux.conf` file.
3875e8d to
e1ac979
Compare
|
Some small things otherwise looks good to me |
|
@omernaveedxyz Reping, i keep it open for another two days, when nothing happens this will get closed. |
|
Apologies for the delay. I was away on vacation last week and did not have access to my device for testing. I've made the recommended changes to the scripts and tested them on my personal machine. Please let me know if there are any concerns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one last thing, otherwise looks good to me ^^
🛑 New scripts must first be submitted to ProxmoxVED for testing.
PRs for new scripts that skip this process will be closed.
✍️ Description
🔗 Related PR / Issue
Link: community-scripts/ProxmoxVE#5166
✅ Prerequisites (X in brackets)
🛠️ Type of Change (X in brackets)
README,AppName.md,CONTRIBUTING.md, or other docs.🔍 Code & Security Review (X in brackets)
Code_Audit.md&CONTRIBUTING.mdguidelinesAppName.sh,AppName-install.sh,AppName.json)📋 Additional Information (optional)
The only hard-coded value is the default admin user password is set toAdmin user password is now generated.changeme. Once logged in, the user can change the password in the UI.