Skip to content

Conversation

@jf---
Copy link
Contributor

@jf--- jf--- commented Aug 18, 2025

updated dependencies compas from 1.17 to 2.13
(oops missed the doctests pls give me a moment)

updated dependencies ``compas`` from 1.17 to 2.13
Copy link
Member

@gonzalocasas gonzalocasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looking good, the addition of rhino3dm to requirements I think needs to change to dev reqs (unless I am missing something). Also, we need to fix the CI to update to the latest, we could try to ask the Copilot agent to do it in this same pull request if you agree

@jf---
Copy link
Contributor Author

jf--- commented Aug 19, 2025

Thanks for the review @gonzalocasas.

Generally looking good, the addition of rhino3dm to requirements I think needs to change to dev reqs (unless I am missing something).

Yeah makes sense

Also, we need to fix the CI to update to the latest, we could try to ask the Copilot agent to do it in this same pull request if you agree

Sure.

Copy link
Member

@gonzalocasas gonzalocasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gonzalocasas gonzalocasas merged commit a64f3a0 into compas-dev:main Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants