Minor refactor #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames and move things about to align with the naming of similar things so I can PR the changes upstream.
mattgodbolt
commented
Jan 8, 2025
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| set -euo pipefail | |||
|
|
|||
| TEMPLATE_FILE=terraform-aws-github-runner/images/ubuntu-focal/github_agent.ubuntu.arm64.pkr.hcl | |||
| TEMPLATE_FILE=terraform-aws-github-runner/images/ubuntu-focal-arm64/github_agent.ubuntu.pkr.hcl | |||
There was a problem hiding this comment.
it's dumb this lives in another diretory but that's how the "jammy" arm64 one is set up.
mattgodbolt
commented
Jan 8, 2025
| @@ -15,4 +15,4 @@ global_tags = { | |||
| Site = "CompilerExplorer" | |||
| Subsystem = "CI" | |||
| } | |||
| instance_profile = "XaniaBlog" | |||
| iam_instance_profile = "XaniaBlog" | |||
There was a problem hiding this comment.
I renamed this in the PR I sent to philips: https://github.com/philips-labs/terraform-aws-github-runner/pull/4342
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames and move things about to align with the naming of similar things so I can PR the changes upstream.
(FAO @partouf)