Reverts the yum/apt stuff in the submodule #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change in submodule /seems/ not to affect us (anymore?) - reverting it means the only difference between the submodule and the upstream version is just PR'd away in https://github.com/philips-labs/terraform-aws-github-runner/pull/4342 so we can in theory consider killing the submodule once that lands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in submodule /seems/ not to affect us (anymore?) - reverting it means the only difference between the submodule and the upstream version is just PR'd away in https://github.com/philips-labs/terraform-aws-github-runner/pull/4342 so we can in theory consider killing the submodule once that lands.
cc @partouf
I built both the arm64 and x64 and did test builds on both. They seem to work.