Skip to content

Conversation

@yxsamliu
Copy link
Contributor

add rocm-cmake since device library now depends on it.

add rocm-cmake since device library now depends on it.
@mattgodbolt mattgodbolt merged commit f348ac5 into compiler-explorer:main Apr 24, 2025
@mattgodbolt
Copy link
Member

@yxsamliu
Copy link
Contributor Author

Build still failed:

https://github.com/compiler-explorer/infra/actions/runs/14642248576/job/41105824789

The log shows:

  + make ce
  make: Nothing to be done for 'ce'.
  + popd
  + /opt/compiler-explorer/infra/bin/ce_install install 'clang-rocm 6.4.0'
  ~
  2025-04-24 17:23:37,803 lib.installation_context INFO     Making uncached requests
  2025-04-24 17:23:37,803 lib.ce_install  INFO     Creating thread pool with 8 workers
  0 packages installed OK, 0 skipped, and 0 failed installation

This is supposed to install clang-rocm 6.4.0 to /opt/compiler-explorer/clang-rocm-6.4.0, but it seems not.

@mattgodbolt
Copy link
Member

Unfortunately it seems clang-rocm-6.4.0 fails to build:

https://github.com/compiler-explorer/infra/actions/runs/14697053906/job/41240138790

  [2561/4931] Building CXX object tools/clang/lib/Basic/CMakeFiles/obj.clangBasic.dir/Targets/MSP430.cpp.o
  [2562/4931] Building CXX object tools/gold/CMakeFiles/LLVMgold.dir/gold-plugin.cpp.o
  FAILED: tools/gold/CMakeFiles/LLVMgold.dir/gold-plugin.cpp.o 
  /opt/compiler-explorer/gcc-9.4.0/bin/g++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/root/build/tools/gold -I/root/llvm-project/llvm/tools/gold -I/root/build/include -I/root/llvm-project/llvm/include -I/opt/compiler-explorer/gcc-9.4.0/lib/gcc/x86_64-linux-gnu/9.4.0/plugin/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17 -fPIC  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT tools/gold/CMakeFiles/LLVMgold.dir/gold-plugin.cpp.o -MF tools/gold/CMakeFiles/LLVMgold.dir/gold-plugin.cpp.o.d -o tools/gold/CMakeFiles/LLVMgold.dir/gold-plugin.cpp.o -c /root/llvm-project/llvm/tools/gold/gold-plugin.cpp
  /root/llvm-project/llvm/tools/gold/gold-plugin.cpp: In lambda function:
  /root/llvm-project/llvm/tools/gold/gold-plugin.cpp:1104:36: error: 'ModuleName' was not declared in this scope; did you mean 'moduleName'?
   1104 |     auto Stream = *AddStream(Task, ModuleName);
        |                                    ^~~~~~~~~~
        |                                    moduleName

@yxsamliu
Copy link
Contributor Author

Unfortunately it seems clang-rocm-6.4.0 fails to build:

https://github.com/compiler-explorer/infra/actions/runs/14697053906/job/41240138790

  [2561/4931] Building CXX object tools/clang/lib/Basic/CMakeFiles/obj.clangBasic.dir/Targets/MSP430.cpp.o
  [2562/4931] Building CXX object tools/gold/CMakeFiles/LLVMgold.dir/gold-plugin.cpp.o
  FAILED: tools/gold/CMakeFiles/LLVMgold.dir/gold-plugin.cpp.o 
  /opt/compiler-explorer/gcc-9.4.0/bin/g++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/root/build/tools/gold -I/root/llvm-project/llvm/tools/gold -I/root/build/include -I/root/llvm-project/llvm/include -I/opt/compiler-explorer/gcc-9.4.0/lib/gcc/x86_64-linux-gnu/9.4.0/plugin/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17 -fPIC  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT tools/gold/CMakeFiles/LLVMgold.dir/gold-plugin.cpp.o -MF tools/gold/CMakeFiles/LLVMgold.dir/gold-plugin.cpp.o.d -o tools/gold/CMakeFiles/LLVMgold.dir/gold-plugin.cpp.o -c /root/llvm-project/llvm/tools/gold/gold-plugin.cpp
  /root/llvm-project/llvm/tools/gold/gold-plugin.cpp: In lambda function:
  /root/llvm-project/llvm/tools/gold/gold-plugin.cpp:1104:36: error: 'ModuleName' was not declared in this scope; did you mean 'moduleName'?
   1104 |     auto Stream = *AddStream(Task, ModuleName);
        |                                    ^~~~~~~~~~
        |                                    moduleName

It depends on compiler-explorer/clang-builder#88

Without compiler-explorer/clang-builder#88, the following patch is missing:

  + ROCM_PATCH=/root/patches/ce-clang-rocm-6.4.0.patch
  + [[ -e /root/patches/ce-clang-rocm-6.4.0.patch ]]

then there will be the compilation error about ModuleName.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants