Skip to content

Commit c565d5b

Browse files
authored
Remove fixed FIXMEs Emscripten shared library build (#528)
1 parent eccc90a commit c565d5b

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

lib/Interpreter/CMakeLists.txt

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -122,12 +122,7 @@ if(EMSCRIPTEN)
122122

123123
# Replace newlines with spaces
124124
string(REPLACE "\n" " " SYMBOLS_LIST "${SYMBOLS_LIST}")
125-
126-
#FIXME: Setting no_soname=1 is needed until https://github.com/emscripten-core/emscripten/blob/ac676d5e437525d15df5fd46bc2c208ec6d376a3/cmake/Modules/Platform/Emscripten.cmake#L36
127-
# is patched out of emsdk, as --soname is not recognised by emscripten. A PR to do this has been done here https://github.com/emscripten-core/emscripten/pull/23453
128-
#FIXME: A patch is needed to llvm to remove -Wl,-z,defs since it is now recognised on emscripten. What needs to be removed is here
129-
# https://github.com/llvm/llvm-project/blob/128e2e446e90c3b1827cfc7d4d19e3c0976beff3/llvm/cmake/modules/HandleLLVMOptions.cmake#L318 . The PR to do try to do this is here
130-
# https://github.com/llvm/llvm-project/pull/123396
125+
131126
set_target_properties(clangCppInterOp
132127
PROPERTIES NO_SONAME 1
133128
)

0 commit comments

Comments
 (0)