Re-enable win tests #206
Re-enable win tests #206
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| static bool exec(const char* cmd, std::vector<std::string>& outputs) { | ||
| #define DEBUG_TYPE "exec" | ||
|
|
||
| std::array<char, 256> buffer; |
There was a problem hiding this comment.
warning: 256 is a magic number; consider replacing it with a named constant [readability-magic-numbers]
std::array<char, 256> buffer;
^|
|
||
| std::string DetectResourceDir(const char* ClangBinaryName /* = clang */) { | ||
| std::string cmd = std::string(ClangBinaryName) + " -print-resource-dir"; | ||
| std::vector<std::string> outs; |
There was a problem hiding this comment.
warning: variable 'outs' is not initialized [cppcoreguidelines-init-variables]
| std::vector<std::string> outs; | |
| std::vector<std::string> outs = 0; |
| cmd += CompilerName; | ||
| cmd += " -xc++ -E -v /dev/null 2>&1 | sed -n -e '/^.include/,${' -e '/^ " | ||
| "\\/.*/p' -e '}'"; | ||
| std::vector<std::string> outs; |
There was a problem hiding this comment.
warning: variable 'outs' is not initialized [cppcoreguidelines-init-variables]
| std::vector<std::string> outs; | |
| std::vector<std::string> outs = 0; |
| #include "llvm/ADT/SmallString.h" | ||
| #include "llvm/Support/Path.h" | ||
|
|
||
| #include <gmock/gmock.h> |
There was a problem hiding this comment.
warning: 'gmock/gmock.h' file not found [clang-diagnostic-error]
#include <gmock/gmock.h>
^| #endif // LLVM_BINARY_DIR || !_WIN32 | ||
| Cpp::CreateInterpreter(); | ||
| EXPECT_STRNE(Cpp::DetectResourceDir().c_str(), Cpp::GetResourceDir()); | ||
| llvm::SmallString<256> Clang(LLVM_BINARY_DIR); |
There was a problem hiding this comment.
warning: 256 is a magic number; consider replacing it with a named constant [readability-magic-numbers]
llvm::SmallString<256> Clang(LLVM_BINARY_DIR);
^| #else | ||
| TEST(InterpreterTest, DetectSystemCompilerIncludePaths) { | ||
| #endif // _WIN32 | ||
| std::vector<std::string> includes; |
There was a problem hiding this comment.
warning: variable 'includes' is not initialized [cppcoreguidelines-init-variables]
| std::vector<std::string> includes; | |
| std::vector<std::string> includes = 0; |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
=======================================
Coverage 78.74% 78.74%
=======================================
Files 8 8
Lines 3091 3091
=======================================
Hits 2434 2434
Misses 657 657 |
vgvassilev
force-pushed
the
re-enable-win-tests
branch
from
af529fc to
1b6cda0
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@vgvassilev I don't know exactly what is causing it to fail . The only thing I can tell from a quick glance is that it appears to have an issue with this line https://github.com/vgvassilev/CppInterOp/blob/1b6cda034fe805f3f9306b35737655631662e6dd/unittests/CMakeLists.txt#L44-L45 |
|
This PR can be closed since its been solved in #313 |
3 participants
@mcbarton, @fsfod, do you have a clue why, although gtest is passing, on windows we get:
More here.