Add llvm libunwind callback to suppress exceptions on apple silicon #254

aaronj0 · 2024-05-02T17:10:47Z

Adding fix from

Cannot catch exceptions on Apple M1 llvm/llvm-project#49036

This adds the find_dynamic_unwind_sections callback, used by libunwind to fix the libc++abi: terminating due to uncaught exception of type int on apple silicon. This returns fake_mach_header as the header for all JIT'd code.

The checks are performed during library loading and unloading time, and so have been added during interpreter creation and destruction called in CppInterOp.cpp, via the leaked compat::Interpreter class

github-actions · 2024-05-02T17:18:22Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-05-02T17:27:35Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-05-02T17:37:32Z

clang-tidy review says "All clean, LGTM! 👍"

codecov · 2024-05-02T17:47:52Z

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 77.36%. Comparing base (d6471b9) to head (1de0745).
Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/CppInterOp/CppInterOp.cpp	30.00%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
+ Coverage   77.31%   77.36%   +0.04%     
==========================================
  Files           9        9              
  Lines        3685     3693       +8     
==========================================
+ Hits         2849     2857       +8     
  Misses        836      836

Files with missing lines	Coverage Δ
lib/CppInterOp/Compatibility.h	`91.96% <ø> (ø)`
lib/CppInterOp/CppInterOp.cpp	`84.72% <30.00%> (+0.06%)`	⬆️

... and 2 files with indirect coverage changes

Files with missing lines	Coverage Δ
lib/CppInterOp/Compatibility.h	`91.96% <ø> (ø)`
lib/CppInterOp/CppInterOp.cpp	`84.72% <30.00%> (+0.06%)`	⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions

clang-tidy made some suggestions

github-actions · 2024-05-02T17:59:44Z

lib/Interpreter/Compatibility.h

 #include "llvm/Support/Casting.h"
 #include "llvm/Support/Path.h"

+/home/maximus/cppyy-interop-dev/CppInterOp/llvm-project/compiler-rt/lib/orc/macho_platform.cpp


warning: expected unqualified-id [clang-diagnostic-error]

/home/maximus/cppyy-interop-dev/CppInterOp/llvm-project/compiler-rt/lib/orc/macho_platform.cpp ^

github-actions · 2024-05-03T08:01:48Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-05-03T08:14:58Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-05-03T08:39:51Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-05-03T08:47:33Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-05-03T09:19:53Z

clang-tidy review says "All clean, LGTM! 👍"

vgvassilev · 2024-05-03T09:27:52Z

@mcbarton, our cache sizes nowadays allow for having 1-2 osx-x86 builds. Are they easy to bring back?

mcbarton · 2024-05-03T09:35:53Z

@mcbarton, our cache sizes nowadays allow for having 1-2 osx-x86 builds. Are they easy to bring back?

@vgvassilev Yes, they are easy to bring back. I'll put in a PR which brings them back.

vgvassilev · 2024-05-03T09:49:40Z

@mcbarton, our cache sizes nowadays allow for having 1-2 osx-x86 builds. Are they easy to bring back?

@vgvassilev Yes, they are easy to bring back. I'll put in a PR which brings them back.

Nice! Thanks for the speed-of-light reply and PR!

github-actions · 2024-05-03T13:53:50Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-05-08T08:00:19Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-05-17T12:27:41Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions

clang-tidy made some suggestions

github-actions · 2024-07-31T06:47:35Z

lib/Interpreter/CppInterOp.cpp

+              dlsym(RTLD_DEFAULT, "__unw_remove_find_dynamic_unwind_sections"))
+        unw_remove_find_dynamic_unwind_sections(find_dynamic_unwind_sections);
+#endif
+      sInterpreter.release();


warning: the value returned by this function should be used [bugprone-unused-return-value]

sInterpreter.release(); ^

Additional context

lib/Interpreter/CppInterOp.cpp:109: cast the expression to void to silence this warning

sInterpreter.release(); ^

github-actions · 2024-12-04T02:44:46Z

This PR is stale because it has been open for 90 days with no activity.

github-actions

clang-tidy made some suggestions

github-actions · 2024-12-05T09:52:46Z

lib/Interpreter/Compatibility.h

 #include "llvm/ADT/StringRef.h"
 #include "llvm/ADT/Twine.h"
+#include "llvm/BinaryFormat/MachO.h"
 #include "llvm/Config/llvm-config.h"


warning: included header MachO.h is not used directly [misc-include-cleaner]

Suggested change

#include "llvm/Config/llvm-config.h"

#include "llvm/Config/llvm-config.h"

github-actions · 2024-12-05T09:52:46Z

lib/Interpreter/Compatibility.h

 #include "llvm/ExecutionEngine/JITSymbol.h"
 #include "llvm/ExecutionEngine/Orc/LLJIT.h"
+#include "llvm/Object/MachO.h"
 #include "llvm/Support/Casting.h"


warning: included header MachO.h is not used directly [misc-include-cleaner]

Suggested change

#include "llvm/Support/Casting.h"

#include "llvm/Support/Casting.h"

anutosh491 · 2025-05-06T13:42:04Z

Hey @aaronj0 was interested in a use case revolving around this ! Would like to know if you would find some time to address whatever remains here ?

vgvassilev · 2025-05-06T13:53:46Z

I think there was something that still needed to be done on the apple side. cc: @lhames.

lhames · 2025-05-07T06:07:30Z

From memory this should be sufficient, but it's been a while since I looked at this. I'd check the error logs but it looks like they've expired. Is there a way to re-run the tests?

anutosh491 · 2025-05-07T06:10:05Z

Is there a way to re-run the tests?

I just rebased the PR on latest main if that would help

github-actions

clang-tidy made some suggestions

github-actions · 2025-05-07T06:16:43Z

unittests/CppInterOp/InterpreterTest.cpp

 #endif
 }
+
+TEST(InterpreterTest, InterpreterExceptions) {


warning: function 'TEST' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]

Suggested change

TEST(InterpreterTest, InterpreterExceptions) {

TESTstatic (InterpreterTest, InterpreterExceptions) {

github-actions · 2025-05-07T06:16:44Z

unittests/CppInterOp/InterpreterTest.cpp

+      << "Failed to catch exceptions in interpreter";
+}
+
+TEST(InterpreterTest, InterpreterExceptionsCompiledCode) {


warning: function 'TEST' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]

Suggested change

TEST(InterpreterTest, InterpreterExceptionsCompiledCode) {

TESTstatic (InterpreterTest, InterpreterExceptionsCompiledCode) {

anutosh491 · 2025-05-07T11:00:44Z

The tests on OSX fail with this https://github.com/compiler-research/CppInterOp/actions/runs/14876386113/job/41774415677?pr=254#step:9:457

See llvm/llvm-project#49036

github-actions

clang-tidy made some suggestions

github-actions · 2025-05-28T06:37:18Z

lib/CppInterOp/Compatibility.h

 #include "llvm/ADT/StringRef.h"
 #include "llvm/ADT/Twine.h"
+#include "llvm/BinaryFormat/MachO.h"
 #include "llvm/Config/llvm-config.h"


warning: included header MachO.h is not used directly [misc-include-cleaner]

Suggested change

#include "llvm/Config/llvm-config.h"

#include "llvm/Config/llvm-config.h"

github-actions · 2025-05-28T06:37:18Z

lib/CppInterOp/Compatibility.h

 #include "llvm/ExecutionEngine/JITSymbol.h"
 #include "llvm/ExecutionEngine/Orc/LLJIT.h"
+#include "llvm/Object/MachO.h"
 #include "llvm/Support/Casting.h"


warning: included header MachO.h is not used directly [misc-include-cleaner]

Suggested change

#include "llvm/Support/Casting.h"

#include "llvm/Support/Casting.h"

vgvassilev · 2025-10-01T05:19:53Z

@aaronj0, can you rebase this PR?

aaronj0 force-pushed the libunwind-fix branch from 1bf40f9 to 2245703 Compare May 2, 2024 17:30

aaronj0 force-pushed the libunwind-fix branch from 2245703 to 06c22ba Compare May 2, 2024 17:52

github-actions bot reviewed May 2, 2024

View reviewed changes

vgvassilev force-pushed the libunwind-fix branch from 971805f to 6516c02 Compare May 3, 2024 08:07

vgvassilev force-pushed the libunwind-fix branch 2 times, most recently from a7ae7ef to be0085b Compare May 3, 2024 08:31

vgvassilev force-pushed the libunwind-fix branch from be0085b to 360d6e5 Compare May 3, 2024 08:40

aaronj0 self-assigned this May 3, 2024

aaronj0 marked this pull request as draft May 3, 2024 11:03

vgvassilev force-pushed the libunwind-fix branch from 6753ee1 to 07f88e2 Compare May 3, 2024 13:46

vgvassilev force-pushed the libunwind-fix branch from 07f88e2 to 0a2a43d Compare May 8, 2024 07:56

aaronj0 force-pushed the libunwind-fix branch from 0a2a43d to c3c8510 Compare May 17, 2024 12:24

aaronj0 added the interpreter label May 17, 2024

vgvassilev force-pushed the libunwind-fix branch from c3c8510 to 3a6db23 Compare July 31, 2024 06:34

github-actions bot reviewed Jul 31, 2024

View reviewed changes

github-actions bot added the stale label Dec 4, 2024

vgvassilev force-pushed the libunwind-fix branch from 3a6db23 to e20f5df Compare December 5, 2024 09:46

github-actions bot reviewed Dec 5, 2024

View reviewed changes

mcbarton added work-in-progress and removed stale labels Dec 6, 2024

mcbarton force-pushed the libunwind-fix branch from d192285 to 02ca483 Compare December 14, 2024 19:33

anutosh491 force-pushed the libunwind-fix branch from 02ca483 to 930930a Compare May 7, 2025 06:09

github-actions bot reviewed May 7, 2025

View reviewed changes

aaronj0 force-pushed the libunwind-fix branch from 930930a to 4d84129 Compare May 12, 2025 12:39

vgvassilev force-pushed the libunwind-fix branch from 4d84129 to dbd2388 Compare May 28, 2025 06:25

Add llvm libunwind callback to suppress exceptions on apple silicon

c0db33d

See llvm/llvm-project#49036

vgvassilev force-pushed the libunwind-fix branch from dbd2388 to c0db33d Compare May 28, 2025 06:26

github-actions bot reviewed May 28, 2025

View reviewed changes

[ci] Add newer osx builders

1de0745

	#include "llvm/Config/llvm-config.h"
	#include "llvm/Config/llvm-config.h"

	#include "llvm/Support/Casting.h"
	#include "llvm/Support/Casting.h"

	TEST(InterpreterTest, InterpreterExceptions) {
	TESTstatic (InterpreterTest, InterpreterExceptions) {

Add llvm libunwind callback to suppress exceptions on apple silicon #254

Are you sure you want to change the base?

Add llvm libunwind callback to suppress exceptions on apple silicon #254

Uh oh!

Conversation

aaronj0 commented May 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 2, 2024

Uh oh!

github-actions bot commented May 2, 2024

Uh oh!

github-actions bot commented May 2, 2024

Uh oh!

codecov bot commented May 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot May 2, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 3, 2024

Uh oh!

github-actions bot commented May 3, 2024

Uh oh!

github-actions bot commented May 3, 2024

Uh oh!

github-actions bot commented May 3, 2024

Uh oh!

github-actions bot commented May 3, 2024

Uh oh!

vgvassilev commented May 3, 2024

Uh oh!

mcbarton commented May 3, 2024

Uh oh!

vgvassilev commented May 3, 2024

Uh oh!

github-actions bot commented May 3, 2024

Uh oh!

github-actions bot commented May 8, 2024

Uh oh!

github-actions bot commented May 17, 2024

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 31, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 4, 2024

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Dec 5, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Dec 5, 2024

Choose a reason for hiding this comment

Uh oh!

anutosh491 commented May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vgvassilev commented May 6, 2025

Uh oh!

lhames commented May 7, 2025

Uh oh!

anutosh491 commented May 7, 2025

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot May 7, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot May 7, 2025

Choose a reason for hiding this comment

aaronj0 commented May 2, 2024 •

edited

Loading

codecov bot commented May 2, 2024 •

edited

Loading

anutosh491 commented May 6, 2025 •

edited

Loading