Fix: resolve nested attributes of anonymous records in GetDatamembers #321

Vipul-Cariappa · 2024-09-12T07:00:39Z

No description provided.

Vipul-Cariappa · 2024-09-12T07:06:09Z

Fixes: https://github.com/Vipul-Cariappa/cppyy-compiler-research/blob/9a73ba6a0cda758991827e51141f3893002dcae5/test/test_datatypes.py#L1562-L1563 and https://github.com/Vipul-Cariappa/cppyy-compiler-research/blob/9a73ba6a0cda758991827e51141f3893002dcae5/test/test_datatypes.py#L1656-L1657 without any extra modification.

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 24. Check the log or trigger a new build to see more.

lib/Interpreter/CppInterOp.cpp

unittests/CppInterOp/VariableReflectionTest.cpp

Vipul-Cariappa · 2024-09-12T07:13:57Z

The test fail with ISO C++ prohibits anonymous structs [-Werror=pedantic], and one of the tests has an anonymous struct.
We have a similar anonymous struct in the cppyy tests.
Should I add -Wno-pedantic to the compiler flags?

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 16. Check the log or trigger a new build to see more.

lib/Interpreter/CppInterOp.cpp

unittests/CppInterOp/VariableReflectionTest.cpp

vgvassilev · 2024-09-12T07:27:37Z

lib/Interpreter/CppInterOp.cpp

+        if (D->getKind() == clang::Decl::Field &&
+            dyn_cast<FieldDecl>(D)->isAnonymousStructOrUnion()) {


Suggested change

if (D->getKind() == clang::Decl::Field &&

dyn_cast<FieldDecl>(D)->isAnonymousStructOrUnion()) {

if (isa<FieldDecl>(D) &&

cast<FieldDecl>(D)->isAnonymousStructOrUnion()) {

I think we should have a proper dyn_cast and isAnonymousStructOrUnion as a nested if...

vgvassilev · 2024-09-12T07:31:14Z

The test fail with ISO C++ prohibits anonymous structs [-Werror=pedantic], and one of the tests has an anonymous struct. We have a similar anonymous struct in the cppyy tests. Should I add -Wno-pedantic to the compiler flags?

Yes, but only for this test file.

github-actions

clang-tidy made some suggestions

lib/Interpreter/CppInterOp.cpp

unittests/CppInterOp/VariableReflectionTest.cpp

Vipul-Cariappa · 2024-09-12T14:07:35Z

Hi @vgvassilev, Valgrind fails. Should I add

if (llvm::sys::RunningOnValgrind())
    GTEST_SKIP() << "XFAIL due to Valgrind report";

?

It is Conditional jump or move depends on uninitialised value(s) at LLVM's code base, according to my eyes.

vgvassilev · 2024-09-12T16:40:16Z

lib/Interpreter/CppInterOp.cpp

+          continue;
+        }
+        Decl* D = *(stack_begin.back());
+        if (D->getKind() == clang::Decl::Field) {


Suggested change

if (D->getKind() == clang::Decl::Field) {

vgvassilev · 2024-09-12T17:05:24Z

lib/Interpreter/CppInterOp.cpp

+      const clang::RecordDecl* RD = FD->getParent();
+      intptr_t offset =
+          C.toCharUnitsFromBits(
+               C.getASTRecordLayout(RD).getFieldOffset(FD->getFieldIndex()))


Suggested change

C.getASTRecordLayout(RD).getFieldOffset(FD->getFieldIndex()))

C.getFieldOffset(FD)

github-actions

clang-tidy made some suggestions

github-actions · 2024-09-13T03:43:01Z

lib/Interpreter/CppInterOp.cpp

+        if (auto* FD = llvm::dyn_cast<FieldDecl>(D)) {
+          if (FD->isAnonymousStructOrUnion()) {
+            if (auto* CXXRD = llvm::dyn_cast_or_null<CXXRecordDecl>(
+                    FD->getType()->getAs<RecordType>()->getDecl())) {


warning: Called C++ object pointer is null [clang-analyzer-core.CallAndMessage]

FD->getType()->getAs<RecordType>()->getDecl())) { ^

Additional context

lib/Interpreter/CppInterOp.cpp:1128: Assuming 'D' is a 'CastReturnType'

if (auto *CXXRD = llvm::dyn_cast_or_null<CXXRecordDecl>(D)) { ^

lib/Interpreter/CppInterOp.cpp:1128: 'CXXRD' is non-null

if (auto *CXXRD = llvm::dyn_cast_or_null<CXXRecordDecl>(D)) { ^

lib/Interpreter/CppInterOp.cpp:1128: Taking true branch

if (auto *CXXRD = llvm::dyn_cast_or_null<CXXRecordDecl>(D)) { ^

lib/Interpreter/CppInterOp.cpp:1134: Loop condition is true. Entering loop body

while (!stack_begin.empty()) { ^

lib/Interpreter/CppInterOp.cpp:1135: Taking false branch

if (stack_begin.back() == stack_end.back()) { ^

lib/Interpreter/CppInterOp.cpp:1141: Assuming 'D' is a 'CastReturnType'

if (auto* FD = llvm::dyn_cast<FieldDecl>(D)) { ^

lib/Interpreter/CppInterOp.cpp:1141: 'FD' is non-null

if (auto* FD = llvm::dyn_cast<FieldDecl>(D)) { ^

lib/Interpreter/CppInterOp.cpp:1141: Taking true branch

if (auto* FD = llvm::dyn_cast<FieldDecl>(D)) { ^

lib/Interpreter/CppInterOp.cpp:1142: Assuming the condition is true

if (FD->isAnonymousStructOrUnion()) { ^

lib/Interpreter/CppInterOp.cpp:1142: Taking true branch

if (FD->isAnonymousStructOrUnion()) { ^

lib/Interpreter/CppInterOp.cpp:1144: Assuming the object is not a 'const RecordType *'

FD->getType()->getAs<RecordType>()->getDecl())) { ^

lib/Interpreter/CppInterOp.cpp:1144: Called C++ object pointer is null

FD->getType()->getAs<RecordType>()->getDecl())) { ^

vgvassilev · 2024-09-13T05:22:02Z

Hi @vgvassilev, Valgrind fails. Should I add
if (llvm::sys::RunningOnValgrind())
    GTEST_SKIP() << "XFAIL due to Valgrind report";
?

It is Conditional jump or move depends on uninitialised value(s) at LLVM's code base, according to my eyes.

Yes, please do.

lib/Interpreter/CppInterOp.cpp

github-actions

clang-tidy made some suggestions

lib/Interpreter/CppInterOp.cpp

github-actions · 2024-09-13T06:22:52Z

lib/Interpreter/CppInterOp.cpp

+    if (auto* FD = llvm::dyn_cast<FieldDecl>(D)) {
+      const clang::RecordDecl* RD = FD->getParent();
+      intptr_t offset =
+          C.toCharUnitsFromBits(C.getFieldOffset(FD)).getQuantity();


warning: narrowing conversion from 'uint64_t' (aka 'unsigned long') to signed type 'int64_t' (aka 'long') is implementation-defined [cppcoreguidelines-narrowing-conversions]

C.toCharUnitsFromBits(C.getFieldOffset(FD)).getQuantity(); ^

github-actions · 2024-09-13T06:22:52Z

lib/Interpreter/CppInterOp.cpp

+            break;
+          }
+        }
+        offset += C.toCharUnitsFromBits(C.getFieldOffset(FD)).getQuantity();


warning: narrowing conversion from 'uint64_t' (aka 'unsigned long') to signed type 'int64_t' (aka 'long') is implementation-defined [cppcoreguidelines-narrowing-conversions]

offset += C.toCharUnitsFromBits(C.getFieldOffset(FD)).getQuantity(); ^

codecov · 2024-09-13T06:22:55Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.69%. Comparing base (ea73105) to head (36f9aee).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
+ Coverage   73.44%   73.69%   +0.25%     
==========================================
  Files           8        8              
  Lines        2990     3019      +29     
==========================================
+ Hits         2196     2225      +29     
  Misses        794      794

Files with missing lines	Coverage Δ
lib/Interpreter/CppInterOp.cpp	`79.54% <100.00%> (+0.34%)`	⬆️

Files with missing lines	Coverage Δ
lib/Interpreter/CppInterOp.cpp	`79.54% <100.00%> (+0.34%)`	⬆️

Co-authored-by: Vassil Vassilev <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

vgvassilev

Lgtm!

fixed by compiler-research/CppInterOp#321

Fix: resolve nested attributes of anonymous records in GetDatamembers

a801568

github-actions bot reviewed Sep 12, 2024

View reviewed changes

Apply suggestions from code review (github-actions bot)

846796b

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions bot reviewed Sep 12, 2024

View reviewed changes

vgvassilev reviewed Sep 12, 2024

View reviewed changes

Vipul-Cariappa added 2 commits September 12, 2024 13:47

suggestions from code review & disable anonymous struct warning for test

a2fd87e

disabling warning if not windows

e837ec6

github-actions bot reviewed Sep 12, 2024

View reviewed changes

vgvassilev reviewed Sep 12, 2024

View reviewed changes

Apply suggestions from code review

34f0c4c

github-actions bot reviewed Sep 13, 2024

View reviewed changes

suggestions from code review & skip test on valgrind

e8dd9a1

vgvassilev reviewed Sep 13, 2024

View reviewed changes

lib/Interpreter/CppInterOp.cpp Outdated Show resolved Hide resolved

lib/Interpreter/CppInterOp.cpp Outdated Show resolved Hide resolved

github-actions bot reviewed Sep 13, 2024

View reviewed changes

Vipul-Cariappa and others added 2 commits September 13, 2024 12:07

Apply suggestions from code review

25cf88d

Co-authored-by: Vassil Vassilev <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

clang format change

36f9aee

vgvassilev approved these changes Sep 13, 2024

View reviewed changes

vgvassilev merged commit 33546ba into compiler-research:main Sep 13, 2024
59 checks passed

Vipul-Cariappa mentioned this pull request Sep 17, 2024

Fix: AttributeError with anonymous unions compiler-research/CPyCppyy#57

Closed

Vipul-Cariappa added a commit to Vipul-Cariappa/cppyy-compiler-research that referenced this pull request Sep 17, 2024

removing xfail on anonymous struct and union tests

75be085

fixed by compiler-research/CppInterOp#321

Vipul-Cariappa mentioned this pull request Sep 17, 2024

removing xfail on anonymous struct and union tests compiler-research/cppyy#99

Merged

Vipul-Cariappa added a commit to Vipul-Cariappa/cppyy-compiler-research that referenced this pull request Sep 19, 2024

removing xfail on anonymous struct and union tests

e7b29cd

fixed by compiler-research/CppInterOp#321

Vipul-Cariappa added a commit to Vipul-Cariappa/cppyy-compiler-research that referenced this pull request Sep 19, 2024

removing xfail on anonymous union test

0f355df

fixed by compiler-research/CppInterOp#321

aaronj0 pushed a commit to compiler-research/cppyy that referenced this pull request Sep 19, 2024

removing xfail on anonymous union test

f4f859f

fixed by compiler-research/CppInterOp#321

Vipul-Cariappa deleted the Anonymous branch September 28, 2024 04:16

		if (D->getKind() == clang::Decl::Field &&
		dyn_cast<FieldDecl>(D)->isAnonymousStructOrUnion()) {

	C.getASTRecordLayout(RD).getFieldOffset(FD->getFieldIndex()))
	C.getFieldOffset(FD)

Uh oh!

Fix: resolve nested attributes of anonymous records in GetDatamembers #321

Fix: resolve nested attributes of anonymous records in GetDatamembers #321

Uh oh!

Conversation

Vipul-Cariappa commented Sep 12, 2024

Uh oh!

Vipul-Cariappa commented Sep 12, 2024

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Vipul-Cariappa commented Sep 12, 2024

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vgvassilev Sep 12, 2024

Choose a reason for hiding this comment

Uh oh!

vgvassilev Sep 12, 2024

Choose a reason for hiding this comment

Uh oh!

vgvassilev commented Sep 12, 2024

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Vipul-Cariappa commented Sep 12, 2024

Uh oh!

vgvassilev Sep 12, 2024

Choose a reason for hiding this comment

Uh oh!

vgvassilev Sep 12, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 13, 2024

Choose a reason for hiding this comment

Uh oh!

vgvassilev commented Sep 13, 2024

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot Sep 13, 2024

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Sep 13, 2024 •

edited

Loading