Resolve static attributes of records

[Vipul-Cariappa]

Fixes: test04_class_read_access and test05_class_data_write_access with one-liner change in cppyy.

[Vipul-Cariappa]

@vgvassilev, Should this change be extracted to a separate function GetStaticDatamembers? If we extract it to a separate function we will have to modify CPyCppyy slightly.

[aaronj0]

@vgvassilev, Should this change be extracted to a separate function GetStaticDatamembers? If we extract it to a separate function we will have to modify CPyCppyy slightly.

I think it is better to make this a separate interface, but we don't need changes in CPyCppyy. Since clingwrapper currently expects static data members with this interface we can stack the results ofCpp::GetDatamembers and then Cpp::GetStaticDatamembers, onto the same std::vector in the Cppyy::GetDatamembers interface

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.71%. Comparing base (33546ba) to head (4ff92da).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
+ Coverage   73.69%   73.71%   +0.01%     
==========================================
  Files           8        8              
  Lines        3019     3021       +2     
==========================================
+ Hits         2225     2227       +2     
  Misses        794      794              

Files with missing lines	Coverage Δ
include/clang/Interpreter/CppInterOp.h	96.00% <ø> (ø)
lib/Interpreter/CppInterOp.cpp	79.57% <100.00%> (+0.02%)	⬆️

Files with missing lines	Coverage Δ
include/clang/Interpreter/CppInterOp.h	96.00% <ø> (ø)
lib/Interpreter/CppInterOp.cpp	79.57% <100.00%> (+0.02%)	⬆️

[Vipul-Cariappa]

The failing tests need to be fixed in cppyy with the following patch:

diff --git a/python/cppyy/__init__.py b/python/cppyy/__init__.py
index 53b7e92..c5d7a3b 100644
--- a/python/cppyy/__init__.py
+++ b/python/cppyy/__init__.py
@@ -133,6 +133,7 @@ def _standard_pythonizations(pyclass, name):
                 return other == -1 or  int(self) == other
             def __ne__(self, other):
                 return other != -1 and int(self) != other
+        del pyclass.__class__.npos          # drop b/c is const data
         pyclass.npos = NPOS(pyclass.npos)
 
     return True

Taken from master.

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[vgvassilev]

We should pass the std::vector as an out parameter.

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[vgvassilev]

LGTM! @aaronj0, what do you think?