-
Couldn't load subscription status.
- Fork 35
Improve template instantiation for GetMethodTemplate
#326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ebb2291 to
23fea95
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
23fea95 to
92a7d61
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
I suspect this needs tests. Otherwise lgtm. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
==========================================
+ Coverage 73.71% 74.30% +0.58%
==========================================
Files 8 8
Lines 3021 3191 +170
==========================================
+ Hits 2227 2371 +144
- Misses 794 820 +26
... and 6 files with indirect coverage changes
|
@vgvassilev This allows the calls like |
92a7d61 to
8315f8c
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
No description provided.