Update cling in ci to version 1.1 using roots llvm 16

.github/workflows/ci.yml

@@ -53,12 +53,12 @@ jobs:
             cppyy: On
             llvm_enable_projects: "clang"
             llvm_targets_to_build: "host;NVPTX"
-          - name: ubu22-x86-gcc9-clang13-cling
+          - name: ubu22-x86-gcc12-clang16-cling
             os: ubuntu-22.04
-            compiler: gcc-9
-            clang-runtime: '13'
+            compiler: gcc-12
+            clang-runtime: '16'
             cling: On
-            cling-version: '1.0'
+            cling-version: '1.1'
             cppyy: On
             llvm_enable_projects: "clang"
             llvm_targets_to_build: "host;NVPTX"
@@ -118,12 +118,12 @@ jobs:
             cppyy: On
             llvm_enable_projects: "clang"
             llvm_targets_to_build: "host;NVPTX"
-          - name: osx14-arm-clang-clang13-cling
+          - name: osx14-arm-clang-clang16-cling
             os: macos-14
             compiler: clang
-            clang-runtime: '13'
+            clang-runtime: '16'
             cling: On
-            cling-version: '1.0'
+            cling-version: '1.1'
             cppyy: On
             llvm_enable_projects: "clang"
             llvm_targets_to_build: "host;NVPTX"
@@ -159,12 +159,12 @@ jobs:
             cppyy: On
             llvm_enable_projects: "clang"
             llvm_targets_to_build: "host;NVPTX"
-          - name: osx13-x86-clang-clang13-cling
+          - name: osx13-x86-clang-clang16-cling
             os: macos-13
             compiler: clang
-            clang-runtime: '13'
+            clang-runtime: '16'
             cling: On
-            cling-version: '1.0'
+            cling-version: '1.1'
             cppyy: On
             llvm_enable_projects: "clang"
             llvm_targets_to_build: "host;NVPTX"
@@ -366,6 +366,13 @@ jobs:
           git clone https://github.com/root-project/cling.git
           cd ./cling 
           git checkout tags/v${{ matrix.cling-version }}
+          # Apply patches
+          llvm_vers=$(echo "${{ matrix.clang-runtime }}" | tr '[:lower:]' '[:upper:]')
+          if [[ "${llvm_vers}" == "16" ]]; then
+            # cling version 1.1 with llvm 16 requires a patch to fix error handling when parsing invaild code
+            git apply -v ../patches/llvm/cling${{ matrix.clang-runtime }}-*.patch
+            echo "Apply cling${{ matrix.clang-runtime }}-*.patch patches:"
+          fi
           cd ..
           git clone --depth=1 -b cling-llvm${{ matrix.clang-runtime }} https://github.com/root-project/llvm-project.git
         else # repl
@@ -392,8 +399,10 @@ jobs:
                 ../llvm
           cmake --build . --target clang --parallel ${{ env.ncpus }}
           cmake --build . --target cling --parallel ${{ env.ncpus }}
-          # Now build gtest.a and gtest_main for CppInterOp to run its tests.
-          cmake --build . --target gtest_main --parallel ${{ env.ncpus }}
+          if [[ "${{ matrix.clang-runtime}}" == "13" ]]; then
+            # Now build gtest.a and gtest_main for CppInterOp to run its tests.
+            cmake --build . --target gtest_main --parallel ${{ env.ncpus }}
+          fi
         else
           # Apply patches
           llvm_vers=$(echo "${{ matrix.clang-runtime }}" | tr '[:lower:]' '[:upper:]')
@@ -433,6 +442,11 @@ jobs:
           git clone https://github.com/root-project/cling.git
           cd ./cling 
           git checkout tags/v${{ matrix.cling-version }}
+          if ( "${{ matrix.clang-runtime }}" -imatch "16" )
+          {
+            # cling version 1.1 with llvm 16 requires a patch to fix error handling when parsing invaild code
+            git apply -v clang16-1-Error-Handling.patch
+          }
           cd ..
           git clone --depth=1 -b cling-llvm${{ matrix.clang-runtime }} https://github.com/root-project/llvm-project.git
           $env:PWD_DIR= $PWD.Path
@@ -466,8 +480,12 @@ jobs:
                 ..\llvm
           cmake --build . --config Release --target clang --parallel ${{ env.ncpus }}
           cmake --build . --config Release --target cling --parallel ${{ env.ncpus }}
-          # Now build gtest.a and gtest_main for CppInterOp to run its tests.
-          cmake --build . --config Release --target gtest_main --parallel ${{ env.ncpus }}
+          if ( "${{ matrix.clang-runtime }}" -imatch "13" )
+          {
+            # cling version 1.0 with llvm 13 doesn't work on Windows, but this is here in
+            # case someone finds a way to fix this
+            cmake --build . --config Release --target gtest_main --parallel ${{ env.ncpus }}
+          }
         }
         else
         {
@@ -552,13 +570,13 @@ jobs:
             clang-runtime: '16'
             cling: Off
             cppyy: Off
-          - name: ubu22-x86-gcc9-clang13-cling-cppyy
+          - name: ubu22-x86-gcc12-clang16-cling
             os: ubuntu-22.04
-            compiler: gcc-9
-            clang-runtime: '13'
+            compiler: gcc-12
+            clang-runtime: '16'
             cling: On
-            cling-version: '1.0'
-            cppyy: On
+            cling-version: '1.1'
+            cppyy: Off
           #FIXME: Windows CppInterOp tests expected to fail
           #until https://github.com/compiler-research/CppInterOp/issues/188 is solved
           - name: win2022-msvc-clang-repl-19
@@ -609,13 +627,13 @@ jobs:
             clang-runtime: '16'
             cling: Off
             cppyy: Off
-          - name: osx14-arm-clang-clang13-cling-cppyy
+          - name: osx14-arm-clang-clang16-cling
             os: macos-14
             compiler: clang
-            clang-runtime: '13'
+            clang-runtime: '16'
             cling: On
-            cling-version: '1.0'
-            cppyy: On
+            cling-version: '1.1'
+            cppyy: Off
           - name: osx13-x86-clang-clang-repl-19-cppyy
             os: macos-13
             compiler: clang
@@ -640,13 +658,13 @@ jobs:
             clang-runtime: '16'
             cling: Off
             cppyy: Off
-          - name: osx13-x86-clang-clang13-cling-cppyy
+          - name: osx13-x86-clang-clang16-cling
             os: macos-13
             compiler: clang
-            clang-runtime: '13'
+            clang-runtime: '16'
             cling: On
-            cling-version: '1.0'
-            cppyy: On
+            cling-version: '1.1'
+            cppyy: Off
 
     steps:
     - uses: actions/checkout@v4

patches/llvm/cling16-1-Error-Handling.patch

@@ -0,0 +1,17 @@
+diff --git a/lib/Interpreter/IncrementalParser.cpp b/lib/Interpreter/IncrementalParser.cpp
+index 89cd78d..2aea40d 100644
+--- a/lib/Interpreter/IncrementalParser.cpp
++++ b/lib/Interpreter/IncrementalParser.cpp
+@@ -911,8 +911,11 @@ namespace cling {
+     PP.EnterSourceFile(FID, /*DirLookup*/nullptr, NewLoc);
+     m_Consumer->getTransaction()->setBufferFID(FID);
+
+-    if (!ParseOrWrapTopLevelDecl())
++    llvm::Expected<bool> res = ParseOrWrapTopLevelDecl();
++    if (!res) {
++      llvm::consumeError(std::move(res.takeError()));
+       return kFailed;
++    }
+
+     if (PP.getLangOpts().DelayedTemplateParsing) {
+       // Microsoft-specific:

unittests/CppInterOp/CUDATest.cpp

@@ -9,7 +9,10 @@ using namespace TestUtils;
 
 static bool HasCudaSDK() {
   auto supportsCudaSDK = []() {
-#if CLANG_VERSION_MAJOR < 16
+#ifdef USE_CLING
+// FIXME: Enable this for cling.
+    return false;
+#elif CLANG_VERSION_MAJOR < 16
     // FIXME: Enable this for cling.
     return false;
 #endif // CLANG_VERSION_MAJOR < 16
@@ -23,7 +26,10 @@ static bool HasCudaSDK() {
 
 static bool HasCudaRuntime() {
   auto supportsCuda = []() {
-#if CLANG_VERSION_MAJOR < 16
+#ifdef USE_CLING
+// FIXME: Enable this for cling.
+    return false;
+#elif CLANG_VERSION_MAJOR < 16
     // FIXME: Enable this for cling.
     return false;
 #endif //CLANG_VERSION_MAJOR < 16
@@ -43,6 +49,8 @@ static bool HasCudaRuntime() {
 
 #if CLANG_VERSION_MAJOR < 16
 TEST(DISABLED_CUDATest, Sanity) {
+#elif USE_CLING
+TEST(DISABLED_CUDATest, Sanity) {
 #else
 TEST(CUDATest, Sanity) {
 #endif // CLANG_VERSION_MAJOR < 16