Fix assert for external interpreter #367
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #367 +/- ##
==========================================
- Coverage 76.31% 76.15% -0.16%
==========================================
Files 8 8
Lines 3137 3137
==========================================
- Hits 2394 2389 -5
- Misses 743 748 +5
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
aaronj0
force-pushed
the
fix-assert
branch
3 times, most recently
from
6309657 to
12d45fc
Compare
|
|
||
| #if !defined(NDEBUG) || !GTEST_HAS_DEATH_TEST | ||
| // death tests don't work right on windows | ||
| #ifndef _WIN32 |
There was a problem hiding this comment.
I thought this was covered by GTEST_HAS_DEATH_TEST. Did anything in particular fail?
There was a problem hiding this comment.
Yes, it doesn't hit the assertion:
1: Actual msg: 1: [ DEATH ] Unable to find target for this triple (no targets are registered)
There was a problem hiding this comment.
Shouldn't we do #if !defined(NDEBUG) && !GTEST_HAS_DEATH_TEST?
There was a problem hiding this comment.
We do that, we do not need the _WIN32 thing...
Yes, it doesn't hit the assertion:
1: Actual msg: 1: [ DEATH ] Unable to find target for this triple (no targets are registered)
Seems a different problem...
No description provided.