-
Couldn't load subscription status.
- Fork 35
Add Emscripten Build Instructions #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Emscripten Build Instructions #390
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #390 +/- ##
==========================================
+ Coverage 70.62% 70.84% +0.21%
==========================================
Files 9 9
Lines 3500 3529 +29
==========================================
+ Hits 2472 2500 +28
- Misses 1028 1029 +1 |
|
@anutosh491 I am aware if the weird formatting and will fix before it gets merged when we are happy with the contents |
4973fdc to
e90a0df
Compare
|
I shall review this soon ! |
|
|
||
| ```bash | ||
| jupyter lite serve --XeusAddon.prefix=$PREFIX | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging this with the xeus-cpp changes doesn't make sense as this won't work already. Maybe let's keep this PR to getting an emscripten build for cppinterop ?
Once I raise a PR on xeus-cpp to get xeus-cpp-lite and that goes in I shall change the readme's in both xeus-cpp and cppinterop on how to get xeus-cpp-lite ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anutosh491 I'll wait until you make the change to get xeus-cpp-lite working. I'll change accordingly if necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xeus-cpp-lite build instructions need to be edited but otherwise looks good. Merging after CI passes.

Description
Please include a summary of changes, motivation and context for this PR.
This PR will add instructions on how to build a wasm version of CppInterOp and xeus-cpp.
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist