Skip to content

Conversation

@mcbarton
Copy link
Collaborator

Description

Please include a summary of changes, motivation and context for this PR.

This PR will add instructions on how to build a wasm version of CppInterOp and xeus-cpp.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

  • I have read the contribution guide recently

@mcbarton mcbarton added the documentation Improvements or additions to documentation label Dec 12, 2024
@mcbarton mcbarton requested a review from anutosh491 December 12, 2024 20:44
@codecov
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.84%. Comparing base (4959cce) to head (0783abf).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
+ Coverage   70.62%   70.84%   +0.21%     
==========================================
  Files           9        9              
  Lines        3500     3529      +29     
==========================================
+ Hits         2472     2500      +28     
- Misses       1028     1029       +1     

see 2 files with indirect coverage changes

see 2 files with indirect coverage changes

@anutosh491
Copy link
Collaborator

Overall formatting looks a bit weird, I don't know why that happens but everything seems left aligned.
Can't we have the docs to fit the page ?

image

@mcbarton
Copy link
Collaborator Author

@anutosh491 I am aware if the weird formatting and will fix before it gets merged when we are happy with the contents

@mcbarton mcbarton force-pushed the Add-emscripten-build-instructions branch from 4973fdc to e90a0df Compare December 17, 2024 17:07
@anutosh491
Copy link
Collaborator

I shall review this soon !


```bash
jupyter lite serve --XeusAddon.prefix=$PREFIX
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this with the xeus-cpp changes doesn't make sense as this won't work already. Maybe let's keep this PR to getting an emscripten build for cppinterop ?

Once I raise a PR on xeus-cpp to get xeus-cpp-lite and that goes in I shall change the readme's in both xeus-cpp and cppinterop on how to get xeus-cpp-lite ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anutosh491 I'll wait until you make the change to get xeus-cpp-lite working. I'll change accordingly if necessary.

Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xeus-cpp-lite build instructions need to be edited but otherwise looks good. Merging after CI passes.

@anutosh491 anutosh491 merged commit c9df3e3 into compiler-research:main Dec 18, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants