Cppyy bug #401
Merged
Cppyy bug #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #401 +/- ##
==========================================
+ Coverage 70.84% 70.87% +0.03%
==========================================
Files 9 9
Lines 3529 3533 +4
==========================================
+ Hits 2500 2504 +4
Misses 1029 1029
|
|
@Vipul-Cariappa All tests pass locally, though I can see a bunch of clang - tidy suggestions. Can you have a look ? |
That needs to be fixed at CppInterOp reference: look at comments at compiler-research/cppyy-backend#116
vgvassilev
force-pushed
the
cppyy_bug
branch
from
d218666 to
18562fa
Compare
Vipul-Cariappa
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Looks good to me.
Enables test03_stllike_preinc at cppyy.
We should consider "squash and merge" and update the comment message to something more meaningful.
I might be a contributor for the poor initial commit message.
@vgvassilev if you can also approve this. I will go ahead and merge.
lib/Interpreter/CppInterOp.cpp
Outdated
| { | ||
| auto D = (Decl *) var; | ||
| TCppType_t GetVariableType(TCppScope_t var) { | ||
| auto D = (Decl*)var; |
There was a problem hiding this comment.
You should be able to satisfy clang-tidy with this
Suggested change
| auto D = (Decl*)var; | |
| auto *D = static_cast<Decl*>(var); |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
vgvassilev
reviewed
Dec 19, 2024
vgvassilev
approved these changes
Dec 19, 2024
Vipul-Cariappa
added a commit
to Vipul-Cariappa/cppyy-compiler-research
that referenced
this pull request
Jan 6, 2025
`test03_stllike_preinc` fixed by compiler-research/CppInterOp#401 others fixed by compiler-research/CppInterOp#394
Vipul-Cariappa
added a commit
to compiler-research/cppyy
that referenced
this pull request
Jan 6, 2025
`test03_stllike_preinc` fixed by compiler-research/CppInterOp#401 others fixed by compiler-research/CppInterOp#394
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
Fixes #365
Type of change
Please tick all options which are relevant.
Checklist