Skip to content

Conversation

@mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented Dec 19, 2024

Description

Please include a summary of changes, motivation and context for this PR.

This PR will separate the emscripten and non emscripten builds into separate workflows, to make them easier to maintain and update.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

  • I have read the contribution guide recently

@codecov
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.87%. Comparing base (cb640db) to head (5c5947f).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
+ Coverage   70.84%   70.87%   +0.03%     
==========================================
  Files           9        9              
  Lines        3529     3533       +4     
==========================================
+ Hits         2500     2504       +4     
  Misses       1029     1029              

see 1 file with indirect coverage changes

see 1 file with indirect coverage changes

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcbarton mcbarton merged commit c506b8c into compiler-research:main Dec 19, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants