Skip to content

Conversation

@mcbarton
Copy link
Collaborator

Description

Please include a summary of changes, motivation and context for this PR.

We are unlikely to ever have Windows builds passing all tests building against llvm 17 and 18. After #463 is merged this PR should be merged, so we can remove the cache used up by these jobs. Keeping the llvm 19 build makes sure our Windows build doesn't break. With the freed up cache space I plan to replace these 2 Windows jobs with Ubuntu 24.04 x86 coverage, which is a good trade.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

  • I have read the contribution guide recently

@codecov
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.15%. Comparing base (54c9482) to head (37a2340).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #464   +/-   ##
=======================================
  Coverage   71.15%   71.15%           
=======================================
  Files           9        9           
  Lines        3550     3550           
=======================================
  Hits         2526     2526           
  Misses       1024     1024           

@mcbarton mcbarton requested a review from vgvassilev January 19, 2025 10:14
@mcbarton mcbarton merged commit ca29de3 into compiler-research:main Jan 19, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant