Prefix the interpreter cmake options

[aaronj0]

Prefix USE_REPL and USE_CLING

[mcbarton]

@aaronj0 I don't understand the motivation for this change. Seems random. The PR description doesn't say why it needs to be done, just what is being done.

cc @vgvassilev

Also the workflows (and probably the code too even though I haven't checked) in cppyy and related repos all assume the old options, so will break a lot of things. If any other repo which builds on CppInterOp we don't work on is using the old options they will break too.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.29%. Comparing base (be5141c) to head (c562c1c).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #505   +/-   ##
=======================================
  Coverage   71.29%   71.29%           
=======================================
  Files           9        9           
  Lines        3567     3567           
=======================================
  Hits         2543     2543           
  Misses       1024     1024           

Files with missing lines	Coverage Δ
lib/Interpreter/CXCppInterOp.cpp	22.09% <ø> (ø)
lib/Interpreter/Compatibility.h	88.28% <ø> (ø)
lib/Interpreter/CppInterOp.cpp	80.60% <ø> (ø)

Files with missing lines	Coverage Δ
lib/Interpreter/CXCppInterOp.cpp	22.09% <ø> (ø)
lib/Interpreter/Compatibility.h	88.28% <ø> (ø)
lib/Interpreter/CppInterOp.cpp	80.60% <ø> (ø)

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[aaronj0]

@aaronj0 I don't understand the motivation for this change. Seems random. The PR description doesn't say why it needs to be done, just what is being done.

cc @vgvassilev

Also the workflows (and probably the code too even though I haven't checked) in cppyy and related repos all assume the old options, so will break a lot of things. If any other repo which builds on CppInterOp we don't work on is using the old options they will break too.

This is not random. This is a requirement for ROOT and has been discussed with @vgvassilev
USE_CLING does not specify which library this options is for and is not good practice for Cmake, when integrating with projects with a larger build tree. This is what LLVM does too, as you can see all their options are prefixed with LLVM_

[aaronj0]

@mcbarton As for your concerns about the workflows, it's something that can be just updated. Other than the cppyy repos, xeus does not use this option anywhere since InterOp is not configured in any way and uses clang-repl by default.

[mcbarton]

@aaronj0 I don't understand the motivation for this change. Seems random. The PR description doesn't say why it needs to be done, just what is being done.
cc @vgvassilev
Also the workflows (and probably the code too even though I haven't checked) in cppyy and related repos all assume the old options, so will break a lot of things. If any other repo which builds on CppInterOp we don't work on is using the old options they will break too.

This is not random. This is a requirement for ROOT and has been discussed with @vgvassilev USE_CLING does not specify which library this options is for and is not good practice for Cmake, when integrating with projects with a larger build tree. This is what LLVM does too, as you can see all their options are prefixed with LLVM_

Even so, its best to have this reason in the PR description, because without it, anybody stumbling across the PR who was not party to the conversation between you and @vgvassilev would have no idea why this change was made. Can you make the required changes in the cppyy related repos, so they don't break with this change?

[vgvassilev]

LGTM. It's quite annoying that so many yaml files had to be updated.

[vgvassilev]

@aaronj0 I don't understand the motivation for this change. Seems random. The PR description doesn't say why it needs to be done, just what is being done.
cc @vgvassilev
Also the workflows (and probably the code too even though I haven't checked) in cppyy and related repos all assume the old options, so will break a lot of things. If any other repo which builds on CppInterOp we don't work on is using the old options they will break too.

This is not random. This is a requirement for ROOT and has been discussed with @vgvassilev USE_CLING does not specify which library this options is for and is not good practice for Cmake, when integrating with projects with a larger build tree. This is what LLVM does too, as you can see all their options are prefixed with LLVM_

Even so, its best to have this reason in the PR description, because without it, anybody stumbling across the PR who was not party to the conversation between you and @vgvassilev would have no idea why this change was made. Can you make the required changes in the cppyy related repos, so they don't break with this change?

That was an urgent request from our ROOT client and we need to act quickly...